91464[TASK] Use system resource API to resolve resources in getFileAbsFileName
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Benjamin Kott +1
- Benni Mack +1
-
Verified V +2 Done
- Helmut Hummel +2
- Benjamin Kott +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 22
- Build/phpstan/phpstan-baseline.neon+0 −12
- typo3/sysext/backend/Classes/Module/ModuleFactory.php+0 −5
- typo3/sysext/backend/Classes/Template/PageRendererBackendSetupTrait.php+2 −2
- typo3/sysext/core/Classes/Imaging/IconProvider/AbstractSvgIconProvider.php+3 −1
- typo3/sysext/core/Classes/Package/Resource/ResourceCollection.php+2 −4
- typo3/sysext/core/Classes/Package/FailsafePackageManager.php+1 −1
- typo3/sysext/core/Classes/Package/Package.php+1 −7
- typo3/sysext/core/Classes/Package/PackageManager.php+4 −8
- typo3/sysext/core/Classes/SystemResource/Identifier/PackageResourceIdentifier.php+11 −12
- typo3/sysext/core/Classes/SystemResource/Identifier/SystemResourceIdentifierFactory.php+28 −17
- typo3/sysext/core/Classes/SystemResource/Type/PackageResource.php+5 −10
- typo3/sysext/core/Classes/SystemResource/Type/PublicPackageFile.php+6 −7
- typo3/sysext/core/Classes/SystemResource/SystemResourceFactory.php+6 −33
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+25 −5
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+8 −11
- typo3/sysext/core/Classes/Utility/PathUtility.php+4 −2
- typo3/sysext/core/Classes/ServiceProvider.php+0 −1
- typo3/sysext/core/Tests/Functional/Imaging/IconProvider/SvgSpriteIconProviderTest.php+3 −2
- typo3/sysext/core/Tests/Functional/SystemResource/SystemResourceFactoryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/SystemResource/Identifier/SystemResourceIdentifierFactoryTest.php+0 −1
Review log 1929
Show 24 earlier messages
-
Helmut Hummel uploaded patch set 1 11/10/25, 09:49
-
core-ci voted on patch set 1 V -1 11/10/25, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88815
-
Helmut Hummel uploaded patch set 2
V -111/10/25, 13:24 -
core-ci voted on patch set 2 V -1 11/10/25, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88850
-
Helmut Hummel uploaded patch set 3
V -111/14/25, 12:29 -
core-ci voted on patch set 3 V -1 11/14/25, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89687
-
Helmut Hummel uploaded patch set 4
V -111/14/25, 12:46 -
core-ci voted on patch set 4 V -1 11/14/25, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89690
-
Helmut Hummel rebased onto patch set 5
V -111/14/25, 19:27 -
core-ci voted on patch set 5 V -1 11/14/25, 19:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89716
-
Helmut Hummel uploaded patch set 6 11/15/25, 09:01
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 6 V -1 11/15/25, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89771
-
Helmut Hummel uploaded patch set 7
V -111/17/25, 19:31 -
core-ci voted on patch set 7 V +1 11/17/25, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89962
-
Helmut Hummel uploaded patch set 8
V +111/18/25, 11:38 -
core-ci voted on patch set 8 V -1 11/18/25, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90014
-
Helmut Hummel uploaded patch set 9
V -111/18/25, 12:44 -
core-ci voted on patch set 9 V +1 11/18/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90021
-
Benni Mack voted on patch set 9 CR +1 11/18/25, 16:27
-
Benni Mack voted on patch set 9 V +1 11/19/25, 18:52
-
Helmut Hummel uploaded patch set 10
CR +1V +111/20/25, 11:28 -
core-ci voted on patch set 10 V +1 11/20/25, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90269
-
Benni Mack voted on patch set 10 CR +1 V +1 11/20/25, 12:51
-
Benjamin Kott commented on patch set 10 CR +1 V +1 11/20/25, 14:52
I have read the code and it looks fine and i understand the changes - but i am not need enough inside the topic to really have a qualified understanding if everything is correct and should be done that way. I can verify the changes, and everything seems to work as expected. -
Helmut Hummel voted on patch set 10 CR +2 V +2 11/24/25, 09:31
-
Helmut Hummel commented on patch set 10 V 0 CR -2 11/24/25, 09:39
Will check if acceptance tests are actually green before merging -
Helmut Hummel voted on patch set 10 CR +2 V +2 11/24/25, 09:58
-
Helmut Hummel commented on patch set 10 11/24/25, 09:58
tests are green: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91847 -
Helmut Hummel merged patch set 11 11/24/25, 09:58