Review main Merged

91464[TASK] Use system resource API to resolve resources in getFileAbsFileName

Helmut Hummel CR +2 V +2 Hard +128 −147 updated 11/24/25, 09:58

Commit message

One of the main concepts of the system resources API is,
that resources are represented by objects. Object representation
is required to identify, distinguish and operate on resources
in a speaking and meaningful way in code.

Obtaining an absolute file system path from such resource violates
this concept, especially, when this string is manipulated or passed
around later on.

Despite this violation and in order to establish a more consistent state
regarding the possible usage of PKG: resources,
GeneralUtility::getFileAbsFileName() is changed to use the resource
API, instead of relying on the PackageManager only to resolve absolute
file system paths from a given resource identifier.

This mitigates the breakage in PageRenderer hooks, that now only
expose PKG: identifiers in internal properties, while these
properties are also delivered to hooks of third party extensions.

It also allows usage of the PKG: resource identifiers across the system,
including Fluid template paths.

While this improves the current state, until the core code base is ready
to work on resource objects only, obtaining the absolute path of a PKG:
resources is introduced and deprecated right away to communicate that this
concept violation will only exist for a short period of time and will be
removed until release of TYPO3 14LTS.

To allow the usage of the system resource API in getFileAbsFileName
the API is refactored in a way to have less duplicate dependencies
and is more concise in what responsibilities which code area has.

Specifically, the identifier handling is now responsible
for validity of the resource and having a dependency to package
management, whereas the resource objects themselves became more
lightweight.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Benjamin Kott +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Benjamin Kott +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 22

Show 2 more files

Review log 1929

Show 24 earlier messages
  1. Helmut Hummel uploaded patch set 1 11/10/25, 09:49

  2. core-ci voted on patch set 1 V -1 11/10/25, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88815

  3. Helmut Hummel uploaded patch set 2 V -1 11/10/25, 13:24

  4. core-ci voted on patch set 2 V -1 11/10/25, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88850

  1. Helmut Hummel uploaded patch set 3 V -1 11/14/25, 12:29

  2. core-ci voted on patch set 3 V -1 11/14/25, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89687

  3. Helmut Hummel uploaded patch set 4 V -1 11/14/25, 12:46

  4. core-ci voted on patch set 4 V -1 11/14/25, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89690

  5. Helmut Hummel rebased onto patch set 5 V -1 11/14/25, 19:27

  6. core-ci voted on patch set 5 V -1 11/14/25, 19:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89716

  7. Helmut Hummel uploaded patch set 6 11/15/25, 09:01

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  8. core-ci voted on patch set 6 V -1 11/15/25, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89771

  9. Helmut Hummel uploaded patch set 7 V -1 11/17/25, 19:31

  10. core-ci voted on patch set 7 V +1 11/17/25, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89962

  11. Helmut Hummel uploaded patch set 8 V +1 11/18/25, 11:38

  12. core-ci voted on patch set 8 V -1 11/18/25, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90014

  13. Helmut Hummel uploaded patch set 9 V -1 11/18/25, 12:44

  14. core-ci voted on patch set 9 V +1 11/18/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90021

  15. Benni Mack voted on patch set 9 CR +1 11/18/25, 16:27

  16. Benni Mack voted on patch set 9 V +1 11/19/25, 18:52

  17. Helmut Hummel uploaded patch set 10 CR +1 V +1 11/20/25, 11:28

  18. core-ci voted on patch set 10 V +1 11/20/25, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90269

  19. Benni Mack voted on patch set 10 CR +1 V +1 11/20/25, 12:51

  20. Benjamin Kott commented on patch set 10 CR +1 V +1 11/20/25, 14:52

    I have read the code and it looks fine and i understand the changes - but i am not need enough inside the topic to really have a qualified understanding if everything is correct and should be done that way. I can verify the changes, and everything seems to work as expected.
  21. Helmut Hummel voted on patch set 10 CR +2 V +2 11/24/25, 09:31

  22. Helmut Hummel commented on patch set 10 V 0 CR -2 11/24/25, 09:39

    Will check if acceptance tests are actually green before merging
  23. Helmut Hummel voted on patch set 10 CR +2 V +2 11/24/25, 09:58

  24. Helmut Hummel commented on patch set 10 11/24/25, 09:58

  25. Helmut Hummel merged patch set 11 11/24/25, 09:58