Review main Merged

91466[TASK] Adjust wording in EXT:extensionmanager

Riccardo De Contardi CR +2 V +2 Easy +16 −21 updated 11/13/25, 10:50

Commit message

Remove exclamation marks from the messages in EXT:extensionmanager and
change the title of the info message on composer status to sound less
patronizing.

Also remove superfluous question output.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Jasmina Ließmann +1

Issues 1

Files 2

Review log 3141

Show 1116 earlier messages
  1. Riccardo De Contardi uploaded patch set 1 11/10/25, 10:46

  2. Mathias Brodala commented on patch set 1 11/10/25, 10:49

    locallang.xlf:638

    > Everything up to date
  3. core-ci voted on patch set 1 V +1 11/10/25, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88827

  4. Riccardo De Contardi commented on patch set 1 11/10/25, 10:57

    locallang.xlf:638 Reply

    You're right, but wouldn't that make the message below a bit of a repetition? - Everything up to date - Extension %s does not need to be updated
  5. Mathias Brodala commented on patch set 1 11/10/25, 11:01

    locallang.xlf:638 Reply

    A little but it's bearable. Otherwise the title can be dropped if it does not add anything useful. A very generic title does not add anything either. ;-)
  6. Riccardo De Contardi uploaded patch set 2 V +1 11/10/25, 11:11

  7. Riccardo De Contardi commented on patch set 2 11/10/25, 11:11

    I'll keep the title for now.

    locallang.xlf:638 Reply

    Done
  8. Mathias Brodala voted on patch set 2 CR +1 11/10/25, 11:13

  9. core-ci voted on patch set 2 V +1 11/10/25, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88833

  10. Riccardo De Contardi rebased onto patch set 3 CR +1 V +1 11/10/25, 15:05

  11. Riccardo De Contardi updated the commit message in patch set 4 11/10/25, 15:06

  12. Riccardo De Contardi uploaded patch set 5 11/10/25, 15:07

  13. Riccardo De Contardi commented on patch set 6 11/10/25, 15:08

    Published edit on patch set 5.
  14. core-ci voted on patch set 3 V +1 11/10/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88861

  15. core-ci voted on patch set 4 V +1 11/10/25, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88862

  16. core-ci voted on patch set 5 V +1 11/10/25, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88863

  1. core-ci voted on patch set 6 V +1 11/10/25, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88864

  2. Josua Vogel voted on patch set 6 CR +1 V +1 11/10/25, 20:56

  3. Jasmina Ließmann commented on patch set 6 11/10/25, 21:42

    locallang.xlf:252

    The last letter ("?") can be removed, right? Additional note: Since I don't currently have a non-composer test setup, I can't assess whether changing the text from a question to a description is appropriate for the context.

    locallang.xlf:289

    The newly added second `%s` is outside the <h3> markup. Is this intentional?
  4. Lina Wolf commented on patch set 6 11/11/25, 04:07

    locallang.xlf:252 Reply

    You can test this with the monorepository installation, it is still running in non-composer mode
  5. Riccardo De Contardi commented on patch set 7 CR +1 V +1 11/11/25, 08:07

    Published edit on patch set 6.
  6. Riccardo De Contardi commented on patch set 7 11/11/25, 08:08

    Actually a typo. Thank you for noticing it.

    locallang.xlf:252 Reply

    Done
  7. Riccardo De Contardi commented on patch set 7 11/11/25, 08:14

    locallang.xlf:289 Reply

    It's actually present on the original code since... forever I guess as I can trace it down on GitHub since version 6
  8. core-ci voted on patch set 7 V +1 11/11/25, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88949

  9. Lina Wolf commented on patch set 7 11/11/25, 08:18

    locallang.xlf:289 Reply

    I think this is outside the scope of the current PR, we cannot resolve every problem there might be with any label in it.
  10. Garvin Hicking commented on patch set 7 11/11/25, 23:54

    locallang.xlf:252

    I think we should be less specific here. When we might rename backend module labels and refer to them like this, we'll forget about it. Better stay more abstract: "When the extension is removed, its source files are deleted, but the related database tables and data will remain unchanged. Please perform a database comparison to ensure integrity."
  11. Riccardo De Contardi commented on patch set 7 11/12/25, 08:21

    locallang.xlf:252 Reply

    Good suggestion. It's better " Please perform a database comparison to ensure integrity." or "Please update the database to ensure integrity"?
  12. Garvin Hicking commented on patch set 7 11/12/25, 10:19

    locallang.xlf:252 Reply

    I always found the term of "perform a database compare" or "DB compare" a bit confusing, however it seems to be a common term and referenced multiple times. But your sentence would work fine for me, too!
  13. Riccardo De Contardi commented on patch set 8 V +1 11/12/25, 10:25

    Published edit on patch set 7.
  14. Riccardo De Contardi commented on patch set 8 11/12/25, 10:26

    locallang.xlf:252 Reply

    Done
  15. core-ci voted on patch set 8 V +1 11/12/25, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89235

  16. Garvin Hicking commented on patch set 8 CR +1 V +1 11/12/25, 11:12

    locallang.xlf:289 Reply

    Done
  17. Lina Wolf voted on patch set 8 CR +1 V +1 11/12/25, 13:37

  18. Garvin Hicking updated the commit message in patch set 9 CR +1 V +1 11/13/25, 10:36

  19. Garvin Hicking updated the commit message in patch set 10 11/13/25, 10:36

  20. Garvin Hicking voted on patch set 10 CR +1 V +1 11/13/25, 10:36

  21. Jasmina Ließmann commented on patch set 10 CR +1 V +1 11/13/25, 10:42

    locallang.xlf:289 Reply

    Ah, I see, my mistake.
  22. Garvin Hicking voted on patch set 10 CR +2 V +2 11/13/25, 10:47

  23. Garvin Hicking merged patch set 11 11/13/25, 10:47

  24. core-ci voted on patch set 9 V +1 11/13/25, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89464

  25. core-ci voted on patch set 10 V +1 11/13/25, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89465