Review main Merged

91470[TASK] Utilize translation domain in scheduler task related showitems

Lina Wolf CR +2 V +2 Easy +9 −6 updated 11/14/25, 19:16

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2028

Show 23 earlier messages
  1. Lina Wolf uploaded patch set 1 11/10/25, 11:40

  2. core-ci voted on patch set 1 V +1 11/10/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88835

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 11/10/25, 15:15

  1. Benni Mack commented on patch set 1 CR -1 11/10/25, 19:47

    This patch is not breaking, as the according strings + TCA was only introduced in 14.0 (= never released)
  2. Lina Wolf updated the commit message in patch set 2 CR +1 V +1 11/11/25, 03:30

  3. Lina Wolf commented on patch set 3 11/11/25, 03:31

    Published edit on patch set 2.
  4. Lina Wolf commented on patch set 4 11/11/25, 03:31

    Published edit on patch set 3.
  5. Lina Wolf commented on patch set 5 11/11/25, 03:32

    Published edit on patch set 4.
  6. Lina Wolf commented on patch set 5 11/11/25, 03:35

    Reply

    Removed the breaking hints
  7. core-ci voted on patch set 2 V +1 11/11/25, 03:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88928

  8. core-ci voted on patch set 3 V +1 11/11/25, 03:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88929

  9. core-ci voted on patch set 4 V +1 11/11/25, 03:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88930

  10. core-ci voted on patch set 5 V +1 11/11/25, 03:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88931

  11. Benni Mack commented on patch set 5 11/11/25, 09:55

    tabs.xlf:5

    let's just move this to the tabs.xlf in EXT:core... I think that's fine to have this as well for others to be available
  12. Lina Wolf uploaded patch set 6 V +1 11/13/25, 21:31

  13. Lina Wolf commented on patch set 6 11/13/25, 21:32

    tabs.xlf:5 Reply

    Done
  14. core-ci voted on patch set 6 V +1 11/13/25, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89596

  15. Benni Mack voted on patch set 6 CR +1 V +1 11/14/25, 15:11

  16. Jasmina Ließmann commented on patch set 6 CR -1 11/14/25, 16:06

    tx_scheduler_task.php:79

    I would like to stick with the `tablename.fieldname` scheme. Specifically: Leave this line as it was before and only change the value of the language key from "Task parameters" to "Settings".
  17. Benni Mack commented on patch set 7 CR +1 V +1 11/14/25, 18:56

    Published edit on patch set 6.
  18. Benni Mack commented on patch set 7 11/14/25, 18:56

    tx_scheduler_task.php:79 Reply

    Done
  19. Benni Mack voted on patch set 7 CR +1 V +1 11/14/25, 18:56

  20. core-ci voted on patch set 7 V +1 11/14/25, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89713

  21. Jasmina Ließmann updated the commit message in patch set 8 CR +1 V +1 11/14/25, 19:06

  22. Jasmina Ließmann voted on patch set 8 CR +1 V +1 11/14/25, 19:06

  23. core-ci voted on patch set 8 V +1 11/14/25, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89714

  24. Benni Mack voted on patch set 8 CR +2 V +2 11/14/25, 19:16

  25. Benni Mack merged patch set 9 11/14/25, 19:16