91470[TASK] Utilize translation domain in scheduler task related showitems
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jasmina Ließmann +1
-
Verified V +2 Done
- Benni Mack +2
- Jasmina Ließmann +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Resources/Private/Language/Form/locallang_tabs.xlf+3 −0
- typo3/sysext/scheduler/Classes/EventListener/AddSchedulableCommandsAsNativeTaskTypes.php+1 −1
- typo3/sysext/scheduler/Configuration/TCA/tx_scheduler_task.php2+2 −2
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf+2 −2
- typo3/sysext/scheduler/Resources/Private/Language/locallang_tca.xlf+1 −1
Review log 2028
Show 23 earlier messages
-
Lina Wolf uploaded patch set 1 11/10/25, 11:40
-
core-ci voted on patch set 1 V +1 11/10/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88835
-
Garvin Hicking voted on patch set 1 CR +1 V +1 11/10/25, 15:15
-
Benni Mack commented on patch set 1 CR -1 11/10/25, 19:47
This patch is not breaking, as the according strings + TCA was only introduced in 14.0 (= never released) -
Lina Wolf updated the commit message in patch set 2
CR +1V +111/11/25, 03:30 -
Lina Wolf commented on patch set 3 11/11/25, 03:31
Published edit on patch set 2. -
Lina Wolf commented on patch set 4 11/11/25, 03:31
Published edit on patch set 3. -
Lina Wolf commented on patch set 5 11/11/25, 03:32
Published edit on patch set 4. -
Lina Wolf commented on patch set 5 11/11/25, 03:35
Reply
Removed the breaking hints -
core-ci voted on patch set 2 V +1 11/11/25, 03:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88928
-
core-ci voted on patch set 3 V +1 11/11/25, 03:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88929
-
core-ci voted on patch set 4 V +1 11/11/25, 03:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88930
-
core-ci voted on patch set 5 V +1 11/11/25, 03:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88931
-
Benni Mack commented on patch set 5 11/11/25, 09:55
tabs.xlf:5let's just move this to the tabs.xlf in EXT:core... I think that's fine to have this as well for others to be available -
Lina Wolf uploaded patch set 6
V +111/13/25, 21:31 -
Lina Wolf commented on patch set 6 11/13/25, 21:32
tabs.xlf:5ReplyDone -
core-ci voted on patch set 6 V +1 11/13/25, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89596
-
Benni Mack voted on patch set 6 CR +1 V +1 11/14/25, 15:11
-
Jasmina Ließmann commented on patch set 6 CR -1 11/14/25, 16:06
tx_scheduler_task.php:79I would like to stick with the `tablename.fieldname` scheme. Specifically: Leave this line as it was before and only change the value of the language key from "Task parameters" to "Settings". -
Benni Mack commented on patch set 7
CR +1V +111/14/25, 18:56Published edit on patch set 6. -
Benni Mack commented on patch set 7 11/14/25, 18:56
tx_scheduler_task.php:79ReplyDone -
Benni Mack voted on patch set 7 CR +1 V +1 11/14/25, 18:56
-
core-ci voted on patch set 7 V +1 11/14/25, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89713
-
Jasmina Ließmann updated the commit message in patch set 8
CR +1V +111/14/25, 19:06 -
Jasmina Ließmann voted on patch set 8 CR +1 V +1 11/14/25, 19:06
-
core-ci voted on patch set 8 V +1 11/14/25, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89714
-
Benni Mack voted on patch set 8 CR +2 V +2 11/14/25, 19:16
-
Benni Mack merged patch set 9 11/14/25, 19:16