Review main Merged

91471[BUGFIX] Split workspace AJAX routes into different scopes

Elias Häußler CR +2 V +2 Easy +32 −6 updated 11/11/25, 14:25

Commit message

The `workspace_dispatch` route was hardened in #106983, limiting access
to users with access to the workspaces backend module only. It was
however forgotten that the AJAX route is used in workspace preview
context as well to render buttons, discard changes and send changes to
different stages. Since this functionality must be available to all
backend users having the general workspace functionality, the
appropriate workspace actions are now reflected in a new AJAX route
`workspace_preview`. The new AJAX route does not define route access
permissions – however, an additional access check is now performed in
the new dedicated controller action.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 1214

  1. Elias Häußler uploaded patch set 1 11/10/25, 12:20

  2. Elias Häußler uploaded patch set 2 11/10/25, 12:23

  3. core-ci voted on patch set 1 V -1 11/10/25, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88838

  4. core-ci voted on patch set 2 V +1 11/10/25, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88840

  5. Garvin Hicking commented on patch set 2 CR +1 V +1 11/10/25, 19:40

    (Not a heavy workspace user so I hope I tested it right :D )
  6. Oliver Hader voted on patch set 2 CR +1 V +1 11/10/25, 21:10

  7. Oliver Hader commented on patch set 2 11/11/25, 09:29

    Trying my best with back-porting to v13 currently...
  8. Oliver Hader commented on patch set 2 CR +2 V +2 11/11/25, 12:28

    Reply

    Done
  9. Oliver Hader voted on patch set 2 CR -1 11/11/25, 12:29

  10. Oliver Hader commented on patch set 2 11/11/25, 12:33

    Waiting for more reviews...
  11. Oliver Hader voted on patch set 2 CR +1 11/11/25, 12:33

  12. Oliver Hader voted on patch set 2 CR +2 11/11/25, 14:25

  13. Oliver Hader commented on patch set 2 11/11/25, 14:25

    Reply

    Done
  14. Oliver Hader merged patch set 3 11/11/25, 14:25