Review 13.4 Merged

91485[BUGFIX] Detect `FIRST_INSTALL` in project path as well

Stefan Bürk CR +2 V +2 Normal +223 −8 updated 11/10/25, 19:27

Commit message

In the past, a system administrator who set up TYPO3 had
to create a FIRST_INSTALL in the public path ("htdocs")
to gain access to the installer.

Since the introduction of the composer mode, it is possible
to have the public path in a subfolder as well.

However, people still needed to create the `FIRST_INSTALL`
file in the public path, whereas the project root path is
much more useful and convenient for newcomers.

This patch now:

* Checks for `FIRST_INSTALL` in both project root and
  public path, instead of only the public directory.

* Modified getFirstInstallFilePaths() to scan both paths
  and return the detected files with the absolute path.

* Updates `removeFirstInstallFile()` to delete found
  files using the now returned absolute path and not
  adding a prefix path anymore.

* Adds functional tests for new behavior.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 11/10/25, 19:16

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/10/25, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88897

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 11/10/25, 19:27

  4. Stefan Bürk merged patch set 2 11/10/25, 19:27