Review main Merged

91489[FOLLOWUP] Fix redirect type migration documentation

Simon Schaufelberger CR +2 V +2 Easy +4 −9 updated 11/11/25, 07:20

Commit message

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Lina Wolf +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1419

  1. Simon Schaufelberger uploaded patch set 1 11/10/25, 20:24

  2. core-ci voted on patch set 1 V +1 11/10/25, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88903

  3. Oli Bartsch commented on patch set 2 V +1 11/10/25, 20:34

    Published edit on patch set 1.
  4. Oli Bartsch commented on patch set 2 CR +1 V +1 11/10/25, 20:35

    Actually `'label'` is the correct example. And the Demand example should be removed, as we won't encourage to use this in TCA (see actual patch for more information on this)
  5. Simon Schaufelberger commented on patch set 2 11/10/25, 20:36

  6. core-ci voted on patch set 2 V +1 11/10/25, 20:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88904

  7. Oli Bartsch commented on patch set 2 11/10/25, 20:47

    Reply

    I don't understand. This is a test and no changelog example.
  8. Simon Schaufelberger commented on patch set 2 11/10/25, 20:49

    Reply

    That is why I'm confused as well :) you say label is correct but the test case should reflect that even though it's just a test.
  9. Oli Bartsch commented on patch set 2 11/10/25, 20:58

    Reply

    I mentioned that because my intention when writing the RST was to demonstrate the migration using the label option. For the test, I chose to use the showitem option. From my perspective, these don’t necessarily need to be identical, since the test isn’t meant to cover every possible option. That said, if you prefer, feel free to add the label option to the test as well.
  10. Simon Schaufelberger uploaded patch set 3 CR +1 V +1 11/10/25, 21:05

  11. Simon Schaufelberger uploaded patch set 4 11/10/25, 21:06

  12. Simon Schaufelberger commented on patch set 4 11/10/25, 21:07

    Reply

    Done
  13. core-ci voted on patch set 3 V +1 11/10/25, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88912

  14. core-ci voted on patch set 4 V +1 11/10/25, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88913

  15. Garvin Hicking updated the commit message in patch set 5 V +1 11/11/25, 00:47

  16. core-ci voted on patch set 5 V +1 11/11/25, 00:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88923

  17. Lina Wolf voted on patch set 5 CR +1 V +1 11/11/25, 03:57

  18. Oli Bartsch voted on patch set 5 CR +2 V +2 11/11/25, 07:20

  19. Oli Bartsch merged patch set 6 11/11/25, 07:20