91545[BUGFIX] Read status colors in system information
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 2
Files 7
- Build/Sources/Sass/component/_dropdown.scss+5 −0
- Build/Sources/TypeScript/backend/toolbar/system-information-menu.ts+1 −0
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php4+2 −2
- typo3/sysext/backend/Resources/Private/Templates/ToolbarItems/SystemInformationDropDown.fluid.html+7 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/system-information-menu.js+1 −1
- typo3/sysext/scheduler/Classes/SystemInformation/ToolbarItemProvider.php+0 −1
Review log 2939
Show 1114 earlier messages
-
Dennis Purisevic uploaded patch set 1 11/11/25, 11:05
-
core-ci voted on patch set 1 V +1 11/11/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88984
-
Garvin Hicking voted on patch set 1 CR +1 11/11/25, 23:48
-
Dennis Purisevic uploaded patch set 2
CR +1V +111/20/25, 11:01 -
core-ci voted on patch set 2 V +1 11/20/25, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90262
-
Jasmina Ließmann commented on patch set 2 V -1 11/20/25, 11:58
To improve readability, we generally want to avoid text colors in the "System Information" area. For this reason, they were removed with #99742.This patch partially reverses this change and does not contribute to good readability in all color schemes and themes (e.g. "Light mode" + "Modern" theme). -
Dennis Purisevic commented on patch set 2 11/21/25, 15:26
Reply
I understand that, but the colors have been updated and the contrast is AAA throughout, with a few exceptions for AA in the light/dark classic/modern design. Alternatively, it could be highlighted with a badge, but I think that's too much. For a quick overview, I think it's good to have colored text. And currently, you can define the status, but it's not used. -
Benjamin Franzke uploaded patch set 3
V +104/09/26, 10:05 -
Benjamin Franzke commented on patch set 3 CR +1 V +1 04/09/26, 10:05
Reply
Ack, the contrasts have been fixed in v13, I agree we can reintroduce the behavior to reflect the state that is provided by the system information providers. One exception: I think it was good to remove the coloring of the application context and therefore removed the status indicator, as it is not a semantic success/error state. -
core-ci voted on patch set 3 V +1 04/09/26, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99837
-
Garvin Hicking commented on patch set 3 CR +1 V +1 04/09/26, 10:46
This looks fine to me. @typo3@minapok.eu would the be ok with you to merge+backport? -
Jasmina Ließmann commented on patch set 3 04/13/26, 08:27
Reply
From a UX perspective, I remain opposed to bringing back text colors to the system information panel. The current "Warning" status for the database information is also too difficult to read and doesn't stand out from the background in Light Mode (regardless of whether the contrast has been optimized in previous settings). This makes the information difficult to grasp, and if the status absolutely needs to be highlighted, then in my opinion, this should be implemented differently.Reply
See my previous comments. I don't support this change. So if you want to merge and backport the patch, you'll have to do it yourself.SystemInformationToolbarItem.php:257"InformationStatus::NOTICE->value" has an empty value, therefore a class will never be set in Fluid.SystemInformationToolbarItem.php:269See comment above. -
Garvin Hicking commented on patch set 3 04/13/26, 10:09
Reply
I'm not deep into UX/contrasts, so I'll have to leave it pending for final UX/design approval from "someone".SystemInformationToolbarItem.php:257ReplyYes, that part is intentional: Only if a non-empty value is used, a class would be emited. So only "warning" would be covered here is my understanding.SystemInformationToolbarItem.php:269ReplyDone -
Jasmina Ließmann commented on patch set 3 04/13/26, 10:26
Reply
Done
-
Jasmina Ließmann commented on patch set 3 04/13/26, 10:33
Reply
Resolving this to not block this any further. -
Benjamin Franzke commented on patch set 3 CR -1 04/13/26, 13:17
Reply
I'll respond to your concerns, no need to take your arguments back or unblock, because valid concers to not block, but help. I agree in parts (just coloring the labels does not suffice) and disagree in others and will try to explain. Unresolving this and voting -1 to leave this open for further argumentation. -
Annett Jähnichen commented on patch set 3 04/13/26, 13:53
Reply
I spoke with Ben. The approach is good, but I would suggest a slightly different implementation. I would suggest a design that doesn't color the word itself, but instead places a colored element in front of it. Maybe a red, yellow, or green circle or stripe. -
Benni Mack updated the commit message in patch set 4
CR +1V +104/22/26, 06:45 -
core-ci voted on patch set 4 V +1 04/22/26, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100787
-
Dennis Purisevic uploaded patch set 5
V +105/07/26, 12:01 -
core-ci voted on patch set 5 V +1 05/07/26, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101677
-
Dennis Purisevic commented on patch set 5 05/07/26, 12:12
Reply
I'm back again and have adjusted the approach. Now the icon "actions-circle-full " will be displayed in the status color before the text if the status is not empty. I think this looks the best. -
Jasmina Ließmann wrote 06/22/26, 11:32
Removed reviewer Jasmina Ließmann. -
Josua Vogel updated the commit message in patch set 6
V +106/24/26, 21:03 -
Josua Vogel voted on patch set 6 CR +1 V +1 06/24/26, 21:03
-
core-ci voted on patch set 6 V +1 06/24/26, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103836
-
Benjamin Kott uploaded patch set 7
CR +1V +107/02/26, 10:42 -
Benjamin Kott commented on patch set 7 07/02/26, 10:46
Reply
hey all, i`ve did a pass through the changes and did some slight adjustments by using a new component for that status indications, also removed the indicator for manual runs of the scheduler to have a unified behavior here that concentrates on surfacing warnings and errors only. in addition i´ve added a column to have the text not underflowing the status indicator. i think we can resolve the issue now at this point, and it can be merged when the prepared prepatched are merged: 94656: [BUGFIX] Render scheduler task status consistently in module and CLI | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94656 94651: [TASK] Introduce status indicator component | https://review.typo3.org/c/Packages/TYPO3.CMS/+/94651i´ve adjusted the patch to -
core-ci voted on patch set 7 V -1 07/02/26, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104229
-
core-ci voted on patch set 7 V +1 07/02/26, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104229
-
Garvin Hicking commented on patch set 7 CR +1 07/03/26, 15:33
Generally this works; minor display issue with the "Development" icon for Application Context. -
Benjamin Kott uploaded patch set 8
CR +1V +107/03/26, 17:56 -
Benjamin Kott uploaded patch set 9 07/03/26, 18:02
-
core-ci voted on patch set 8 V +1 07/03/26, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104325
-
core-ci voted on patch set 9 V +1 07/03/26, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104326
-
Garvin Hicking voted on patch set 9 CR +1 V +1 07/03/26, 18:48
-
Benjamin Franzke voted on patch set 9 CR +1 V +1 07/07/26, 09:51
-
Benjamin Kott voted on patch set 9 CR +2 V +2 07/07/26, 09:55
-
Benjamin Kott merged patch set 10 07/07/26, 09:59