Review main Merged

91550[TASK] Migrate module labels to new short label domain

Garvin Hicking CR +2 V +2 Expert +1216 −384 updated 11/12/25, 12:38

Commit message

The new short translation domain for backend module layouts
is now utilized across all backend modules.

The key syntax is:

* `<extensionkey>.modules.<modulename>` - multiple BE modules
  Files put into `Resources/Private/Language/Modules/<modulename>.xlf`.

* `<extensionkey>.module` - single backend module only
  File put into `Resources/Private/Language/module.xlf`.

The single-module language files for EXT:reactions and
EXT:webhooks are moved in the appropriate location, with
a translation domain alias in place.

All other new language domain label files are created
with the old files like `locallang_mod.xlf` getting
deprecated, or single keys for the backend module
descriptions getting deprecated (marked in the XLIFF file).

PHP syntax is adapted to also utlize short-hand domain
language keys in the languageService.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 151

Show 131 more files

Review log 1319

  1. Garvin Hicking uploaded patch set 1 11/11/25, 13:24

  2. core-ci voted on patch set 1 V -1 11/11/25, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88997

  3. Garvin Hicking commented on patch set 1 CR -1 11/11/25, 14:21

  4. Benni Mack uploaded patch set 2 CR -1 V -1 11/11/25, 18:06

  5. core-ci voted on patch set 2 V -1 11/11/25, 18:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89050

  6. Benni Mack uploaded patch set 3 V -1 11/11/25, 18:31

  7. core-ci voted on patch set 3 V +1 11/11/25, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89054

  8. Garvin Hicking commented on patch set 3 CR -1 11/11/25, 19:10

    on it
  9. Garvin Hicking uploaded patch set 4 CR -1 V +1 11/11/25, 20:23

  10. Garvin Hicking uploaded patch set 5 11/11/25, 20:26

  11. core-ci voted on patch set 4 V +1 11/11/25, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89069

  12. core-ci voted on patch set 5 V +1 11/11/25, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89070

  13. Garvin Hicking uploaded patch set 6 V +1 11/11/25, 20:36

  14. Garvin Hicking commented on patch set 6 CR +1 V +1 11/11/25, 20:38

    Reply

    Done
    (voting on Bennis changes, wrapped up the "singular" module identifier naming to not have "workspaces.modules.workspaces" but "workspaces.module")
  15. core-ci voted on patch set 6 V +1 11/11/25, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89071

  16. Stefan Bürk voted on patch set 6 CR +1 V +1 11/11/25, 21:16

  17. Christian Kuhn commented on patch set 6 11/12/25, 09:45

    Modules.php:23

    i've never been a fan of this magic. imho it should go away entirely and substituted with the array that adds the three labels specifically, which is possible already.
  18. Benni Mack commented on patch set 6 CR +2 V +2 11/12/25, 12:38

    Modules.php:23 Reply

    we can sort this out separately IMHO (followup to make it explicit is an easy task then) - The main point is to streamline the XLF file locations and their labels, so we can continue moving along here. I hope it's OK if I resolve this comment. We can continue the discussion separately (as I'm sure we will).
  19. Benni Mack merged patch set 7 11/12/25, 12:38