91552[TASK] Add basic XLIFF validation / linting
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Lina Wolf +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Lina Wolf +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 24
- Build/gitlab-ci/nightly/integrity.yml+1 −0
- Build/gitlab-ci/pre-merge/integrity.yml2+1 −0
- Build/Scripts/checkIntegrityXliff.phpnew+254 −0
- Build/Scripts/runTests.sh+4 −0
- typo3/sysext/backend/Resources/Private/Language/Modules/pagetsconfig.xlf+7 −0
- typo3/sysext/backend/Resources/Private/Language/Modules/pagetsconfig_active.xlf+7 −0
- typo3/sysext/backend/Resources/Private/Language/Modules/pagetsconfig_includes.xlf+7 −0
- typo3/sysext/backend/Resources/Private/Language/Modules/pagetsconfig_pages.xlf+7 −0
- typo3/sysext/backend/Resources/Private/Language/Wizards/move_content_elements.xlf+1 −1
- typo3/sysext/backend/Resources/Private/Language/Wizards/move_page.xlf+1 −1
- typo3/sysext/core/Resources/Private/Language/Modules/content.xlf+4 −0
- typo3/sysext/core/Resources/Private/Language/Modules/help.xlf+4 −0
- typo3/sysext/core/Resources/Private/Language/Modules/media.xlf+4 −0
- typo3/sysext/core/Resources/Private/Language/Modules/system.xlf+4 −0
- typo3/sysext/core/Resources/Private/Language/Modules/tools.xlf+4 −0
- typo3/sysext/core/Resources/Private/Language/Modules/user.xlf+4 −0
- typo3/sysext/info/Resources/Private/Language/Modules/overview.xlf+4 −0
- typo3/sysext/info/Resources/Private/Language/Modules/translations.xlf+4 −0
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+2 −2
- typo3/sysext/tstemplate/Resources/Private/Language/Modules/active.xlf+7 −0
Show 4 more files
- typo3/sysext/tstemplate/Resources/Private/Language/Modules/analyzer.xlf+7 −0
- typo3/sysext/tstemplate/Resources/Private/Language/Modules/constanteditor.xlf+7 −0
- typo3/sysext/tstemplate/Resources/Private/Language/Modules/infomodify.xlf+7 −0
- typo3/sysext/tstemplate/Resources/Private/Language/Modules/recordsoverview.xlf+7 −0
Review log 2024
-
Garvin Hicking uploaded patch set 1 11/11/25, 13:30
-
core-ci voted on patch set 1 V -1 11/11/25, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88999
-
Garvin Hicking marked it work in progress 11/11/25, 13:55
-
Garvin Hicking commented on patch set 1 CR -1 11/11/25, 14:21
Depends on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91169 -
Garvin Hicking commented on patch set 2
CR -1V -111/11/25, 14:21Published edit on patch set 1. -
Garvin Hicking commented on patch set 2 CR -1 11/11/25, 14:22
Reply
unresolve -
core-ci voted on patch set 2 V +1 11/11/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89013
-
Garvin Hicking uploaded patch set 3
CR -1V +111/12/25, 16:50 -
Garvin Hicking marked it ready for review 11/12/25, 16:50
-
Garvin Hicking commented on patch set 3 11/12/25, 16:50
Reply
Done -
core-ci voted on patch set 3 V +1 11/12/25, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89374
-
Benni Mack voted on patch set 3 CR +1 V +1 11/12/25, 17:08
-
Oliver Klee commented on patch set 3 11/12/25, 17:47
Would it make sense to use the XLIFF validator that comes with the Symfony Translation component instead (or additionally)? https://github.com/TYPO3BestPractices/tea/blob/main/Build/xliff/xliff-lint -
Garvin Hicking commented on patch set 3 11/12/25, 18:14
Reply
I will resolve this, since the current solution implements what we need at this time and I cannot bring up energy to rework this. I appreciate the hint though. If someone wants to do that at a later time, I would not mind :-) -
Garvin Hicking uploaded patch set 4
CR +1V +111/13/25, 09:16 -
core-ci voted on patch set 4 V +1 11/13/25, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89445
-
Benni Mack voted on patch set 4 CR +1 V +1 11/13/25, 21:26
-
Lina Wolf commented on patch set 4 CR +1 V +1 11/14/25, 06:04
Thanks! This has been needed! -
Garvin Hicking voted on patch set 4 CR +2 V +2 11/14/25, 06:05
-
Garvin Hicking merged patch set 5 11/14/25, 06:05
-
Christian Kuhn commented on patch set 5 11/14/25, 10:25
this by default creates a rather longish list in CI now without value when green. i would prefer more silencing for the already rather complex 'integrity' job. example run: https://git.typo3.org/typo3/CI/cms/-/jobs/5004169integrity.yml:35this should run with php 8.2 as the others. -
Garvin Hicking commented on patch set 5 11/14/25, 10:39
Reply
Yes this was an error of mime. I will fix it in a followup, this was meant for verbose debug -
Lina Wolf commented on patch set 5 11/14/25, 11:22
Reply
Working on a follow up in exchange with Garvin who is afk: https://forge.typo3.org/issues/108125