91556[BUGFIX] Allow `UUID` in `ext_tables.sql` using Doctrine `GuidType`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Simon Praetorius +1
- Sven Liebert +1
-
Verified V +2 Done
- Stefan Bürk +2
- Simon Praetorius +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/core/Classes/Database/Platform/Traits/GetColumnDeclarationSQLCommentTypeAwareTrait.php+10 −0
- typo3/sysext/core/Classes/Database/Schema/Parser/AST/DataType/UuidDataType.phpnew+23 −0
- typo3/sysext/core/Classes/Database/Schema/Parser/Lexer.php+1 −0
- typo3/sysext/core/Classes/Database/Schema/Parser/Parser.php+6 −0
- typo3/sysext/core/Classes/Database/Schema/Parser/TableBuilder.php+7 −0
- typo3/sysext/core/Tests/Functional/Database/Schema/FieldTypeHandling/Fixtures/UuidFieldType/new_not_nullable_and_no_default.sqlnew+7 −0
- typo3/sysext/core/Tests/Functional/Database/Schema/FieldTypeHandling/Fixtures/UuidFieldType/new_nullable_and_no_default.sqlnew+7 −0
- typo3/sysext/core/Tests/Functional/Database/Schema/FieldTypeHandling/UuidFieldTypeTest.phpnew+127 −0
- typo3/sysext/core/Tests/Functional/Database/Schema/AbstractSchemaBasedTestCase.phpnew+207 −0
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+22 −172
- typo3/sysext/core/Tests/Unit/Database/Schema/Fixtures/tablebuilder.sql+2 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/UuidDataTypeTest.phpnew+31 −0
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php+19 −0
Review log 1013
-
Stefan Bürk uploaded patch set 1 11/11/25, 14:47
-
core-ci voted on patch set 1 V +1 11/11/25, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89015
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/11/25, 19:00
-
Garvin Hicking commented on patch set 1 CR +1 V +1 11/11/25, 23:38
Nice! I only tested the "fallback" on mysql and otherwise ran this through the tests only.This aims to improve performance with TCA `type=uuid` on PostgreSQL setups."for most cases" -
Garvin Hicking updated the commit message in patch set 2
CR +1V +111/12/25, 08:50 -
core-ci voted on patch set 2 V +1 11/12/25, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89168
-
Garvin Hicking rebased onto patch set 3
CR +1V +111/24/25, 16:33 -
Sven Liebert voted on patch set 3 CR +1 V +1 11/24/25, 16:43
-
core-ci voted on patch set 3 V +1 11/24/25, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90871
-
Simon Praetorius voted on patch set 3 CR +1 V +1 11/24/25, 16:55
-
Stefan Bürk voted on patch set 3 CR +2 V +2 11/24/25, 16:56
-
Stefan Bürk merged patch set 4 11/24/25, 17:26