Review main Merged

91567[BUGFIX] Enforce "_" over "-" in localization domain naming

Benni Mack CR +2 V +2 Easy +14 −1 updated 11/11/25, 19:09

Commit message

Before, the translation domain mapper
used "backend.modules.content-security-policy" for
"EXT:backend/Resources/Private/Language/Modules/content-security-policy.xlf",
which again actually marked the domain name (isValidDomainName())
as invalid as it contained "-" (invalid for a domain).

The correct transformation thus must be
for "backend.modules.content_security_policy", which now happens.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Simon Praetorius +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Simon Praetorius +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Benni Mack uploaded patch set 1 11/11/25, 18:27

  2. core-ci voted on patch set 1 V +1 11/11/25, 18:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89053

  3. Benni Mack updated the commit message in patch set 2 V +1 11/11/25, 18:40

  4. Garvin Hicking voted on patch set 2 CR +1 V +1 11/11/25, 18:40

  5. core-ci voted on patch set 2 V +1 11/11/25, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89055

  6. Simon Praetorius voted on patch set 2 CR +1 V +1 11/11/25, 19:07

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 11/11/25, 19:09

  8. Garvin Hicking merged patch set 3 11/11/25, 19:09