Review main Merged

91570[TASK] Show breadcrumb in EXT:viewpage for invalid pages

Georg Ringer CR +2 V +2 Easy +3 −0 updated 11/12/25, 08:44

Commit message

Even if no preview is possible, e.g. because it is a sysfolder, the
breadcrumb should still be shown to be able to navigate to a valid
page.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1114

  1. Georg Ringer uploaded patch set 1 11/11/25, 20:45

  2. Georg Ringer commented on patch set 1 11/11/25, 20:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 11/11/25, 20:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89073

  4. Georg Ringer commented on patch set 2 V -1 11/11/25, 20:55

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V +1 11/11/25, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89076

  6. Garvin Hicking voted on patch set 2 CR +1 11/11/25, 23:23

  7. Benni Mack commented on patch set 2 11/12/25, 07:05

    ViewModuleController.php:90

    BackendUtility::readPageAccess() is already called 15 lines above... we can just use $pageInfo
  8. Georg Ringer uploaded patch set 3 CR +1 V +1 11/12/25, 08:11

  9. Georg Ringer commented on patch set 3 11/12/25, 08:11

    ViewModuleController.php:90 Reply

    Done
  10. core-ci voted on patch set 3 V +1 11/12/25, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89133

  11. Oli Bartsch voted on patch set 3 CR +1 V +1 11/12/25, 08:20

  12. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/12/25, 08:23

  13. Oli Bartsch voted on patch set 3 CR +2 V +2 11/12/25, 08:44

  14. Oli Bartsch merged patch set 4 11/12/25, 08:44