Review main Abandoned

91571[TASK] Add root page to breadcrumb in Site configuration

Georg Ringer CR +1 V -1 Easy +10 −0 updated 12/29/25, 16:41

Commit message

Add the root page of the site which is being edited to the breadcrumb,
just as done in the Site Settings.

Review

  • Code review CR +1
    • Garvin Hicking +1
  • Verified V -1
    • Oli Bartsch -1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 11/11/25, 20:54

  2. core-ci voted on patch set 1 V +1 11/11/25, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89075

  3. Georg Ringer updated the commit message in patch set 2 V +1 11/11/25, 21:12

  4. Georg Ringer commented on patch set 2 11/11/25, 21:12

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 11/11/25, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89077

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 11/11/25, 23:23

  7. Oli Bartsch commented on patch set 2 V -1 11/12/25, 08:23

    Unresolved

    IMO the information is oke to be displayed, but clicking on the site returns to the module overview, this does not seem right and does not align with other modules where clicking on the current page does keep the current view. (We might even discuss wether it makes sense to have current page linked at all)
  8. Elias Häußler commented on patch set 2 11/12/25, 08:37

    FYI: There's also https://review.typo3.org/c/Packages/TYPO3.CMS/+/91453 which tries to solve this in a different way.
  9. Oli Bartsch commented on patch set 2 11/12/25, 08:40

    Reply

    Ah you're right. We should stick to this general solution instead of manually fiddling around with the sites in every controller. 👍 @elias@haeussler.dev Would you mind to finish the patch?
  10. Elias Häußler commented on patch set 2 11/12/25, 08:52

    Reply

    Yes, I'll continue with the other patch.
  11. Georg Ringer abandoned the change 12/29/25, 16:41