Review main Merged

91572[BUGFIX] Only encode the record title in workspace integrity messages

Andreas Nedbal CR +2 V +2 Easy +3 −3 updated 11/13/25, 15:45

Commit message

lit handles turning quotes into their respective HTML representations,
so encoding the messages fully leads to double encoding which shows
the integrity messages with """s.

To preserve security, we instead only apply htmlspecialchars() to the
record titles inside the integrity messages.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Garvin Hicking +1
    • Riccardo De Contardi +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1113

  1. Andreas Nedbal uploaded patch set 1 11/11/25, 21:18

  2. core-ci voted on patch set 1 V +1 11/11/25, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89078

  3. Garvin Hicking commented on patch set 1 11/11/25, 23:22

    GridDataService.php:459

    Haven't reviewed this, but since this variable is passed as $dataArray to the PSR events, could we introduce security issues for these event listeners utilizing the 'messages' and passing it to something other than a lit element?
  4. Andreas Nedbal commented on patch set 1 11/12/25, 08:30

    GridDataService.php:459 Reply

    Don't think so? The main change is that quotes are not htmlentities anymore, that at most might introduce rendering issues somewhere, but security shouldn't be impacted with the user-input part (the record title) still being sanitized by htmlspecialchars.
  5. Riccardo De Contardi commented on patch set 1 V +1 11/12/25, 09:15

    tested on latest main
  6. Garvin Hicking commented on patch set 1 CR +1 V +1 11/12/25, 10:10

    GridDataService.php:459 Reply

    Acknowledged
  7. Andreas Nedbal updated the commit message in patch set 2 CR +1 V +1 11/13/25, 08:43

  8. core-ci voted on patch set 2 V +1 11/13/25, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89437

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 11/13/25, 11:25

  10. Riccardo De Contardi commented on patch set 2 V +1 11/13/25, 11:29

    Tested on latest main
  11. Stefan Bürk voted on patch set 2 CR +1 V +1 11/13/25, 15:43

  12. Andreas Nedbal voted on patch set 2 CR +2 V +2 11/13/25, 15:44

  13. Andreas Nedbal merged patch set 3 11/13/25, 15:45