Review main Merged

91574[TASK] Update PHPStan to 2.1.32

Garvin Hicking CR +2 V +2 Easy +7 −32 updated 11/12/25, 10:17

Commit message

Executed commands:

    composer req --dev phpstan/phpstan:^2.1.32 -W
   ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

- ContentObjectRenderer dynamic method call with varying number
  of arguments and method existence is now ignored, as PHPStan
  complains about something that only reflection could solve,
  which is too impactful. This only affects main, because
  only there PHPStan is able to evaluate executed methods.

- RequestHandlerTest performed two useless assertions

- Dropped entries from baseline with false positives

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1215

  1. Garvin Hicking uploaded patch set 1 11/12/25, 09:06

  2. Garvin Hicking uploaded patch set 2 11/12/25, 09:07

  3. core-ci voted on patch set 1 V +1 11/12/25, 09:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89173

  4. core-ci voted on patch set 2 V +1 11/12/25, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89174

  5. Garvin Hicking updated the commit message in patch set 3 V +1 11/12/25, 09:30

  6. Oliver Klee voted on patch set 3 CR +1 11/12/25, 09:34

  7. Oliver Klee voted on patch set 3 CR 0 11/12/25, 09:34

  8. Oliver Klee commented on patch set 3 11/12/25, 09:36

    ContentObjectRenderer.php:1176

    We can make this more specific, allowing PHPStan to still warn us if it finds any other problem: ```suggestion // @phpstan-ignore arguments.count phpstan complains about some methods not having a second argument, which is not required/useful - doing reflection here would be too intense. ```
  9. Oliver Klee voted on patch set 3 V +1 11/12/25, 09:37

  10. Garvin Hicking commented on patch set 3 11/12/25, 09:39

    ContentObjectRenderer.php:1176 Reply

    It's not only arguments.count but also 2 (or 3?) other variants. So I would like to keep that generic (and not touch the backports) if that's fine with you?
  11. core-ci voted on patch set 3 V +1 11/12/25, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89200

  12. Oliver Klee commented on patch set 3 CR +1 11/12/25, 09:46

    ContentObjectRenderer.php:1176 Reply

    Acknowledged
  13. Christian Kuhn commented on patch set 3 CR +1 V +1 11/12/25, 09:49

    ContentObjectRenderer.php:1176 Reply

    solution is fine for the time being, there is similar ignore above already that i added due to the dynamic method call recently.
  14. Garvin Hicking voted on patch set 3 CR +2 V +2 11/12/25, 10:16

  15. Garvin Hicking merged patch set 4 11/12/25, 10:17