Review main Merged

91583[BUGFIX] Prevent double-encoding in FormEngine suggest items

Andreas Nedbal CR +2 V +2 Normal +58 −2 updated 10/30/26, 22:27

Commit message

The suggest wizard fetched record titles prepared for HTML output,
which applies htmlspecialchars(). As the result items and the
selected option are rendered as text in the frontend, special
characters like "&" showed up encoded twice.

The raw record title is now used and only cropped to the configured
title length, keeping the "[No title]" fallback intact.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1422

  1. Andreas Nedbal uploaded patch set 1 11/12/25, 13:12

  2. core-ci voted on patch set 1 V +1 11/12/25, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89317

  3. Andreas Nedbal updated the commit message in patch set 2 V +1 11/13/25, 08:46

  4. Andreas Nedbal updated the commit message in patch set 3 11/13/25, 08:51

  5. core-ci voted on patch set 2 V +1 11/13/25, 08:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89438

  6. core-ci voted on patch set 3 V +1 11/13/25, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89442

  7. Garvin Hicking commented on patch set 3 CR -1 11/13/25, 11:30

    This sadly short-circuits the handling of "[No record title]" and shortening of labels that are too long...
  8. Benni Mack updated the commit message in patch set 4 CR -1 V +1 04/22/26, 06:26

  9. core-ci voted on patch set 4 V -1 04/22/26, 06:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100695

  10. Georg Ringer uploaded patch set 5 V -1 09/30/26, 19:40

  11. core-ci voted on patch set 5 V +1 09/30/26, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109691

  12. Benni Mack updated the commit message in patch set 6 V +1 10/28/26, 15:13

  13. core-ci voted on patch set 6 V -1 10/28/26, 15:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112729

  14. Oli Bartsch uploaded patch set 7 V -1 10/30/26, 21:25

  15. Oli Bartsch voted on patch set 7 CR +1 V +1 10/30/26, 21:26

  16. core-ci voted on patch set 7 V -1 10/30/26, 21:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112913

  17. Oli Bartsch rebased onto patch set 8 CR +1 V +1 10/30/26, 21:37

  18. core-ci voted on patch set 8 V +1 10/30/26, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112918

  19. Oli Bartsch voted on patch set 8 CR +1 V +1 10/30/26, 21:48

  20. Garvin Hicking voted on patch set 8 CR +1 V +1 10/30/26, 22:26

  21. Oli Bartsch voted on patch set 8 CR +2 V +2 10/30/26, 22:27

  22. Oli Bartsch merged patch set 9 10/30/26, 22:27