Review main Merged

91598[TASK] Introduce typo3-backend-content-navigation web component

Benni Mack CR +2 V +2 Nightmare +1892 −699 updated 12/16/25, 06:41

Commit message

This commit introduces a new web component called
typo3-backend-content-navigation that provides a unified and
self-contained solution for resizable split-view layouts consisting of
a navigation panel and a content area.

The new component replaces the previous
typo3-backend-resizable-navigation component by integrating all
resizing logic directly into itself. It uses a slot-based architecture
where navigation and content areas are passed as slotted children,
making it easy to use across different contexts.

The component automatically handles responsive behavior through
container queries, switching to a flyout mode on narrow viewports. It
also persists user preferences for panel width and collapsed state per
identifier using the existing Persistent storage mechanism.

A companion component called typo3-backend-content-navigation-toggle
is included for expand and collapse buttons that automatically detect
their surrounding context and render the appropriate icon and title.

All existing usages have been migrated to the new component, including
the page tree, file tree, element browsers, link browsers, and move
wizards. The scaffold CSS has been simplified significantly since the
layout responsibility now lives inside the component itself.

Documentation for the new component has been added to the styleguide.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 79

Show 59 more files

Review log 4675

Show 2750 earlier messages
  1. Benni Mack uploaded patch set 1 11/12/25, 21:04

  2. core-ci voted on patch set 1 V +1 11/12/25, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89398

  3. Benni Mack uploaded patch set 2 V +1 11/13/25, 21:28

  4. core-ci voted on patch set 2 V +1 11/13/25, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89594

  5. Benjamin Kott uploaded patch set 3 V +1 12/03/25, 09:51

  6. Benjamin Kott commented on patch set 3 CR -1 12/03/25, 09:51

    on it
  7. core-ci voted on patch set 3 V -1 12/03/25, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91511

  8. Benjamin Kott uploaded patch set 4 CR -1 V -1 12/05/25, 13:34

  9. Benjamin Kott commented on patch set 4 CR -1 12/05/25, 13:34

    still on it
  10. core-ci voted on patch set 4 V -1 12/05/25, 13:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91652

  11. Benjamin Kott uploaded patch set 5 CR -1 V -1 12/08/25, 20:26

  12. Benjamin Kott voted on patch set 5 CR -2 12/08/25, 20:26

  13. core-ci voted on patch set 5 V -1 12/08/25, 20:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91838

  14. Benjamin Kott uploaded patch set 6 V -1 12/09/25, 09:27

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  15. core-ci voted on patch set 6 V -1 12/09/25, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91871

  16. Benjamin Kott uploaded patch set 7 V -1 12/09/25, 13:50

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  17. core-ci voted on patch set 7 V -1 12/09/25, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91893

  18. Benjamin Kott uploaded patch set 8 V -1 12/09/25, 15:23

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  19. core-ci voted on patch set 8 V -1 12/09/25, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91909

  20. Benjamin Kott uploaded patch set 9 V -1 12/10/25, 07:33

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  21. core-ci voted on patch set 9 V -1 12/10/25, 07:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91962

  22. Benjamin Kott uploaded patch set 10 V -1 12/10/25, 09:54

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  23. core-ci voted on patch set 10 V -1 12/10/25, 10:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91973

  24. Benjamin Kott uploaded patch set 11 V -1 12/10/25, 11:14

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  25. core-ci voted on patch set 11 V -1 12/10/25, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91974

  26. Benjamin Kott uploaded patch set 12 V -1 12/10/25, 11:31

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  27. core-ci voted on patch set 12 V -1 12/10/25, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91975

  28. Benjamin Kott uploaded patch set 13 V -1 12/10/25, 13:33

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  29. Benjamin Kott uploaded patch set 14 12/10/25, 13:42

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  30. Benjamin Kott uploaded patch set 15 12/10/25, 13:57

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  31. core-ci voted on patch set 13 V -1 12/10/25, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91980

  32. core-ci voted on patch set 14 V -1 12/10/25, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91982

  33. Benjamin Kott uploaded patch set 16 12/10/25, 14:10

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  34. core-ci voted on patch set 15 V -1 12/10/25, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91986

  35. Benjamin Kott uploaded patch set 17 12/10/25, 14:31

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  36. core-ci voted on patch set 16 V -1 12/10/25, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91988

  37. core-ci voted on patch set 17 V -1 12/10/25, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91994

  38. Benjamin Kott uploaded patch set 18 V -1 12/10/25, 15:11

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  39. Benjamin Kott uploaded patch set 19 12/10/25, 15:18

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  40. core-ci voted on patch set 18 V -1 12/10/25, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91996

  41. core-ci voted on patch set 19 V -1 12/10/25, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91997

  42. Benjamin Kott uploaded patch set 20 V -1 12/10/25, 15:35

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  43. core-ci voted on patch set 20 V -1 12/10/25, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92001

  44. Benjamin Kott uploaded patch set 21 V -1 12/10/25, 15:52

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  45. core-ci voted on patch set 21 V -1 12/10/25, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92003

  46. Benjamin Kott uploaded patch set 22 V -1 12/11/25, 07:01

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  47. core-ci voted on patch set 22 V +1 12/11/25, 07:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92048

  48. Benjamin Kott updated the commit message in patch set 23 V +1 12/11/25, 07:21

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  49. Benjamin Kott uploaded patch set 24 12/11/25, 07:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  50. core-ci voted on patch set 23 V +1 12/11/25, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92049

  1. core-ci voted on patch set 24 V +1 12/11/25, 07:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92050

  2. Benjamin Kott uploaded patch set 25 V +1 12/11/25, 08:05

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  3. Benjamin Kott voted on patch set 25 CR 0 12/11/25, 08:06

  4. Benjamin Kott commented on patch set 25 12/11/25, 08:10

    DocHeader.fluid.html:11

    needs to be always loaded, the state is synced with the wrapper and it only renders if it detects the wrapper and the state is collapsed, we cannot make this optional since we do not know for example the navigation context of the formengine for example.

    Main.fluid.html:39

    we are keeping the labels general for now in all implementations, as it´s unclear what sub component is currently active.
  5. core-ci voted on patch set 25 V +1 12/11/25, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92052

  6. Benjamin Kott rebased onto patch set 26 V +1 12/11/25, 17:21

  7. core-ci voted on patch set 26 V +1 12/11/25, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92080

  8. Benjamin Kott voted on patch set 26 CR +1 V +1 12/15/25, 07:19

  9. Oli Bartsch commented on patch set 26 CR -1 12/15/25, 07:39

    review
  10. Oli Bartsch commented on patch set 26 12/15/25, 10:14

    content-navigation-toggle.ts:42

    Could we use an enum here.

    content-navigation.ts:167

    This property seems to be unused.

    content-navigation.ts:173

    What is the benefit of these if we do not use them for differentiation, for example in the page tree or folder tree?
  11. Benjamin Kott commented on patch set 26 12/15/25, 10:57

    content-navigation.ts:167 Reply

    you are right that seems to be a leftover

    content-navigation.ts:173 Reply

    the benefit is that we could use them in the future, and it allows us to assign them from the fluid side for now
  12. Benjamin Kott uploaded patch set 27 CR +1 V +1 12/15/25, 15:33

  13. Benjamin Kott commented on patch set 27 12/15/25, 15:34

    content-navigation-toggle.ts:42 Reply

    Done

    content-navigation.ts:167 Reply

    Done

    content-navigation.ts:173 Reply

    Done
  14. Benjamin Kott uploaded patch set 28 12/15/25, 15:41

  15. core-ci voted on patch set 28 V +1 12/15/25, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92243

  16. core-ci voted on patch set 27 V -1 12/15/25, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92240

  17. Oli Bartsch commented on patch set 28 CR +1 V +1 12/15/25, 16:52

    Reply

    Done
  18. Garvin Hicking voted on patch set 28 V +1 12/15/25, 21:46

  19. Georg Ringer rebased onto patch set 29 CR +1 V +1 12/15/25, 21:49

  20. core-ci voted on patch set 29 V +1 12/15/25, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92254

  21. Oli Bartsch voted on patch set 29 CR +1 V +1 12/15/25, 22:07

  22. Garvin Hicking voted on patch set 29 V +1 12/16/25, 05:41

  23. Georg Ringer voted on patch set 29 CR +1 V +1 12/16/25, 06:37

  24. Benni Mack voted on patch set 29 CR +2 V +2 12/16/25, 06:41

  25. Benni Mack merged patch set 30 12/16/25, 06:41