Review main Abandoned

91601[BUGFIX] Fix styling of callouts without title

Benni Mack CR +1 V +1 Easy +1 −7 updated 11/13/25, 20:05

Commit message

Review

  • Code review CR +1
    • Garvin Hicking +1
  • Verified V +1
    • Garvin Hicking +1
    • Riccardo De Contardi +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 811

  1. Benni Mack uploaded patch set 1 11/12/25, 21:39

  2. Benni Mack rebased onto patch set 2 11/12/25, 21:40

  3. core-ci voted on patch set 1 V -1 11/12/25, 21:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89404

  4. core-ci voted on patch set 2 V -1 11/12/25, 21:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89405

  5. Benni Mack uploaded patch set 3 V -1 11/12/25, 21:50

  6. core-ci voted on patch set 3 V +1 11/12/25, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89407

  7. Garvin Hicking commented on patch set 3 11/12/25, 22:13

    InfoboxViewHelper.php:105

    Should this be ```suggestion if ($title !== '' && $title !== null) { ``` Because now if $title might be null it would create the title callout...?!
  8. Benni Mack commented on patch set 3 11/12/25, 22:15

    InfoboxViewHelper.php:105 Reply

    the main issue here is that it's a regression. $title is cast to string above, and thus, can never be null.
  9. Garvin Hicking commented on patch set 3 CR +1 V +1 11/12/25, 22:20

    InfoboxViewHelper.php:105 Reply

    oh, of course. didn't scroll up, sorry. good night 😄
  10. Riccardo De Contardi commented on patch set 3 V +1 11/13/25, 09:02

    tested on latest main
  11. Garvin Hicking abandoned the change 11/13/25, 20:05