91601[BUGFIX] Fix styling of callouts without title
Commit message
Review
-
Code review CR +1
- Garvin Hicking +1
-
Verified V +1
- Garvin Hicking +1
- Riccardo De Contardi +1
- core-ci +1 CI
Issues 2
Files 2
Review log 811
-
Benni Mack uploaded patch set 1 11/12/25, 21:39
-
Benni Mack rebased onto patch set 2 11/12/25, 21:40
-
core-ci voted on patch set 1 V -1 11/12/25, 21:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89404
-
core-ci voted on patch set 2 V -1 11/12/25, 21:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89405
-
Benni Mack uploaded patch set 3
V -111/12/25, 21:50 -
core-ci voted on patch set 3 V +1 11/12/25, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89407
-
Garvin Hicking commented on patch set 3 11/12/25, 22:13
-
Benni Mack commented on patch set 3 11/12/25, 22:15
InfoboxViewHelper.php:105Replythe main issue here is that it's a regression. $title is cast to string above, and thus, can never be null. -
Garvin Hicking commented on patch set 3 CR +1 V +1 11/12/25, 22:20
InfoboxViewHelper.php:105Replyoh, of course. didn't scroll up, sorry. good night 😄 -
Riccardo De Contardi commented on patch set 3 V +1 11/13/25, 09:02
tested on latest main -
Garvin Hicking abandoned the change 11/13/25, 20:05
solved via https://review.typo3.org/91293
InfoboxViewHelper.php:105