Review main Merged Breaking

91603[!!!][TASK] Remove MailMessage->send()

Christian Kuhn CR +2 V +2 Normal +82 −55 updated 06/18/26, 23:10

Commit message

TYPO3 core mail API is quite messy since it went through
various libraries over time without being properly aligned
to modern standards.

This patch resolves one rather obvious detail: Symfony class
Email is designed as data object but the TYPO3 inheritance
`MailMessage` adds service characteristics by providing `send()`
and `isSent()` for historical reasons.

Services that send mails should rather get an instance of the
`MailerInterface` injected to `send($aMail)`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1014

  1. Christian Kuhn uploaded patch set 1 11/13/25, 00:43

  2. Christian Kuhn updated the commit message in patch set 2 11/13/25, 00:45

  3. core-ci voted on patch set 1 V +1 11/13/25, 00:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89415

  4. core-ci voted on patch set 2 V +1 11/13/25, 00:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89416

  5. Christian Kuhn uploaded patch set 3 V +1 11/13/25, 15:22

  6. Oliver Klee updated the commit message in patch set 4 11/13/25, 15:26

  7. Oliver Klee voted on patch set 4 CR +1 V +1 11/13/25, 15:26

  8. core-ci voted on patch set 3 V +1 11/13/25, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89538

  9. core-ci voted on patch set 4 V +1 11/13/25, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89539

  10. Garvin Hicking commented on patch set 4 CR +1 V +1 11/13/25, 16:54

    good one
  11. Christian Kuhn voted on patch set 4 CR +2 V +2 11/13/25, 17:02

  12. Christian Kuhn merged patch set 5 11/13/25, 17:02

  13. Lina Wolf commented on patch set 5 12/31/25, 08:55

    Documented the situation in V14 here: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/6319 However, using the MailerInterface was already possible with V13 as far as I can see? So it would probably make sense to already change the examples in V13 and issue a warning about the change as unfortunarily the feature was never deprecated for v13 so ppl might miss they still have it until fatal errors when switching to v14
  14. Lina Wolf commented on patch set 5 12/31/25, 08:59

    Reply Unresolved