Review main Merged

91604[BUGFIX] Remember last used action of indexing module

Oli Bartsch CR +2 V +2 Normal +167 −25 updated 10/14/26, 07:02

Commit message

Selecting a page in the page tree, or opening the module via the
module menu, always showed the first action of the "Indexing"
module instead of the one selected before.

The controller tried to restore the last used action from the user
settings. Since Extbase backend modules use explicit routes, the
default route always provides an action, so this code was never
reached. It furthermore stored all request arguments, including
record specific ones.

The module now declares the menu action as module data, stores it
when one of the module menu actions is requested explicitly and
restores it when the module is called via its default route.
Detail views are not remembered.

The page tree keeps linking to the module entry point, leaving it
to the module to decide which state is relevant.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1114

  1. Oli Bartsch uploaded patch set 1 11/13/25, 09:01

  2. core-ci voted on patch set 1 V +1 11/13/25, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89443

  3. Benjamin Franzke commented on patch set 1 CR -1 11/13/25, 13:59

    page-tree-element.ts:457

    I think we need to figure allowed arguments, otherwise be preserve too much State when changing Pages via page module. I think we need API for modules to explicitly announce state that is relevant for this kind of use case. Let's put this on hold for now.
  4. Benni Mack updated the commit message in patch set 2 CR -1 V +1 04/22/26, 06:39

  5. core-ci voted on patch set 2 V -1 04/22/26, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100751

  6. Benni Mack commented on patch set 2 09/11/26, 21:49

    ping. please rebase or abandon
  7. Oli Bartsch uploaded patch set 3 V -1 10/10/26, 08:08

  8. Oli Bartsch commented on patch set 3 10/10/26, 08:15

    Reply

    Done

    page-tree-element.ts:457 Reply

    I fixed this via ModuleData API now.
  9. core-ci voted on patch set 3 V +1 10/10/26, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110769

  10. Benni Mack voted on patch set 3 CR +1 10/10/26, 09:45

  11. Georg Ringer voted on patch set 3 CR +1 V +1 10/12/26, 20:03

  12. Oli Bartsch commented on patch set 3 10/14/26, 06:59

    page-tree-element.ts:457 Reply

    Done
  13. Oli Bartsch voted on patch set 3 CR +2 V +2 10/14/26, 07:02

  14. Oli Bartsch merged patch set 4 10/14/26, 07:02