91608[TASK] Raise deprecation error on using deprecated labels
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Sven Liebert +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Riccardo De Contardi +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Classes/Localization/Loader/XliffLoader.php+13 −6
- typo3/sysext/core/Classes/Localization/LanguageService.php3+17 −0
- typo3/sysext/core/Documentation/Changelog/14.1/Deprecation-108086-RaiseDeprecationErrorOnUsingDeprecatedLabels.rstnew+129 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/fr.locallang.xlf+8 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/fr.messages_2.xlfnew+47 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/locallang.xlf+12 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/messages_2.xlfnew+40 −0
- typo3/sysext/core/Tests/Functional/Localization/LanguageServiceTest.php+102 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/test_translate/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/TranslateViewHelperTest.php4+51 −0
- typo3/sysext/frontend/Tests/Functional/Http/Fixtures/RequestHandlerTestUserFuncs.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Http/RequestHandlerCachingTest.php+1 −1
Review log 3143
Show 1118 earlier messages
-
Lina Wolf uploaded patch set 1 11/13/25, 10:14
-
Lina Wolf updated the commit message in patch set 2 11/13/25, 10:16
-
core-ci voted on patch set 1 V -1 11/13/25, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89456
-
Lina Wolf uploaded patch set 3 11/13/25, 10:29
-
core-ci voted on patch set 2 V -1 11/13/25, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89457
-
Lina Wolf rebased onto patch set 4 11/13/25, 10:35
-
Lina Wolf uploaded patch set 5 11/13/25, 10:39
-
core-ci voted on patch set 3 V -1 11/13/25, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89461
-
core-ci voted on patch set 4 V -1 11/13/25, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89463
-
core-ci voted on patch set 5 V -1 11/13/25, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89468
-
Lina Wolf uploaded patch set 6
V -111/13/25, 11:05 -
core-ci voted on patch set 6 V +1 11/13/25, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89470
-
Garvin Hicking commented on patch set 6 11/13/25, 11:24
Thanks, that's a well-written deprecation ReST! 😊Deprecation-108086-RaiseDeprecationErrorOnUsingDeprecatedLabels.rst:77what about when using this with `->translate()` and `->translateLabel()`?Deprecation-108086-RaiseDeprecationErrorOnUsingDeprecatedLabels.rst:88Also give an example for the "domain" syntax, just to use this to teach the "new way"?TranslateViewHelperTest.php:234please use `'template' => '...', 'expected' => '...'` keys for the array so we are upward compatible with new PHPUnit requirements in the future (or use a generator here as well)TranslateViewHelperTest.php:465(see above) -
Lina Wolf commented on patch set 6 11/13/25, 11:30
Deprecation-108086-RaiseDeprecationErrorOnUsingDeprecatedLabels.rst:77Replytranslate() is still internal, translateLabel() calls sL as do various other methods, for example extbase Localization Factory. Should we mention them all? -
Garvin Hicking commented on patch set 6 11/13/25, 11:47
Deprecation-108086-RaiseDeprecationErrorOnUsingDeprecatedLabels.rst:77ReplyOf course, you're right. Let's keep leaving this out then! -
Oliver Klee updated the commit message in patch set 7
V +111/13/25, 11:55 -
core-ci voted on patch set 7 V +1 11/13/25, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89483
-
Lina Wolf uploaded patch set 8
V +111/13/25, 13:25
-
Lina Wolf commented on patch set 8 11/13/25, 13:27
Deprecation-108086-RaiseDeprecationErrorOnUsingDeprecatedLabels.rst:88ReplyDoneTranslateViewHelperTest.php:234ReplyDoneTranslateViewHelperTest.php:465ReplyDone -
core-ci voted on patch set 8 V +1 11/13/25, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89503
-
Lina Wolf uploaded patch set 9
V +111/15/25, 09:46 -
core-ci voted on patch set 9 V +1 11/15/25, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89777
-
Lina Wolf rebased onto patch set 10
V +111/25/25, 11:41 -
core-ci voted on patch set 10 V +1 11/25/25, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90941
-
Garvin Hicking voted on patch set 10 CR +1 V +1 11/25/25, 12:12
-
Lina Wolf uploaded patch set 11
CR +1V +111/26/25, 11:02 -
Garvin Hicking voted on patch set 11 CR +1 V +1 11/26/25, 11:05
-
Sven Liebert voted on patch set 11 CR +1 V +1 11/26/25, 11:10
-
core-ci voted on patch set 11 V +1 11/26/25, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91014
-
Riccardo De Contardi voted on patch set 11 V +1 11/26/25, 14:26
-
Benni Mack commented on patch set 11 11/26/25, 14:50
do we really like ".deprecated"? I mean... we could do something like "._deprecated" to be really sure, it's not used currently in any project? I don't know. If we agree, we're good with ".deprecated" let's do this. -
Garvin Hicking commented on patch set 11 11/26/25, 14:57
Reply
Fair point, extensions might want to use identifiers called "some_old_api.deprecated" and still emit that label, because not the label itself is deprecated but describes something deprecated. `._deprecated` isn't easy on the eye. How about `.x-unused`? That would be in line with our 'x-unused-since` extension? (If the dash isn't a problem) -
Lina Wolf uploaded patch set 12
CR +1V +111/27/25, 18:53 -
Lina Wolf commented on patch set 12 11/27/25, 18:54
Reply
Done -
core-ci voted on patch set 12 V +1 11/27/25, 19:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91127
-
Riccardo De Contardi commented on patch set 12 V +1 12/01/25, 11:13
verified with a couple of used labels and - old xlf syntax (x-unused-since) - new xlf syntax (subState="deprecated") -
Oliver Klee voted on patch set 12 V +1 12/01/25, 11:21
-
Benni Mack commented on patch set 12 12/02/25, 17:59
LanguageService.php:226when would this happen? When the somebody explicitly calls "mylabel.x-unused"? -
Lina Wolf commented on patch set 12 12/02/25, 18:02
LanguageService.php:226Replyyes, as using labels ending on ".x-unused" is also deprecated -
Benni Mack commented on patch set 12 CR +1 12/03/25, 16:25
LanguageService.php:226ReplyDone -
Sven Liebert voted on patch set 12 CR +1 V +1 12/04/25, 12:36
-
Benni Mack voted on patch set 12 CR +2 V +2 12/05/25, 15:36
-
Benni Mack merged patch set 13 12/05/25, 15:36