Review 13.4 Merged

91613[BUGFIX] Prevent decoding of user supplied URLs in LinkBrowser

Benjamin Franzke CR +2 V +2 Easy +6 −2 updated 11/13/25, 12:28

Commit message

InputTransformer.toSearchParams for some reason decodes search
parameters after assembling them. This causes properly encoded URLs
to be changed, which violates RFC 1738 section
2.2 "All unsafe characters must always be encoded within a URL." [1]

We create an own URLSearchParams object as a workaround, in order
to avoid this faulty behavior, as this ensures that AjaxRequest
uses the values as-is.

The faulty behavior will be fixed separated for v14 only, see #108052.
This workaround is scoped to the reported issue. A followup patch will
address the decoding inside `AjaxRequest(...).withQueryArguments`,
see #108052.

[1] https://www.rfc-editor.org/rfc/rfc1738#section-2.2

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 11/13/25, 11:51

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/13/25, 11:53

  3. core-ci voted on patch set 1 V +1 11/13/25, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89482

  4. Benjamin Franzke merged patch set 2 11/13/25, 12:28