91617[!!!][TASK] Add respectSubmittedDataValue argument in password ViewHelper
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1924
-
Torben Hansen uploaded patch set 1 11/13/25, 14:18
-
core-ci voted on patch set 1 V +1 11/13/25, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89517
-
Garvin Hicking commented on patch set 1 11/13/25, 15:38
Breaking-108093-AddRespectSubmittedDataValueArgumentInPasswordViewHelper.rst:15```suggestion :php:`respectSubmittedDataValue` which allows to configure, if a submitted field ```Breaking-108093-AddRespectSubmittedDataValueArgumentInPasswordViewHelper.rst:16```suggestion value will be put into the HTML response of the form on validation errors after submission. The default value ```Breaking-108093-AddRespectSubmittedDataValueArgumentInPasswordViewHelper.rst:31```suggestion TYPO3 instances using the :fluid:`<f:form.password>` ViewHelper. ``` -
Oliver Klee voted on patch set 1 V +1 11/13/25, 15:38
-
Torben Hansen commented on patch set 2
V +111/13/25, 15:48Published edit on patch set 1. -
Torben Hansen commented on patch set 2 11/13/25, 15:54
Breaking-108093-AddRespectSubmittedDataValueArgumentInPasswordViewHelper.rst:14ReplyFix applied.Breaking-108093-AddRespectSubmittedDataValueArgumentInPasswordViewHelper.rst:15ReplyDoneBreaking-108093-AddRespectSubmittedDataValueArgumentInPasswordViewHelper.rst:16ReplyFix applied.Breaking-108093-AddRespectSubmittedDataValueArgumentInPasswordViewHelper.rst:31ReplyFix applied. -
core-ci voted on patch set 2 V +1 11/13/25, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89545
-
Torben Hansen uploaded patch set 3
V +111/13/25, 15:56 -
Oliver Klee voted on patch set 3 V +1 11/13/25, 15:57
-
core-ci voted on patch set 3 V +1 11/13/25, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89547
-
Garvin Hicking commented on patch set 3 CR +1 V +1 11/13/25, 16:49
********* -
Lina Wolf commented on patch set 3 11/13/25, 21:09
PasswordViewHelper.php:43```suggestion 'If set to false (default), any user-submitted data is not displayed in the output. If set to true, the password is emitted as clear text in the response. This is not recommended from a security point of view.', ``` -
Torben Hansen commented on patch set 3 11/14/25, 08:35
PasswordViewHelper.php:43ReplyFix applied. -
Oliver Hader commented on patch set 4
CR +1V +111/14/25, 08:57Published edit on patch set 3. -
Oliver Hader commented on patch set 4 11/14/25, 08:58
PasswordViewHelper.php:43ReplyFix applied. -
Oliver Hader commented on patch set 5 11/14/25, 08:59
Published edit on patch set 4. -
Oliver Klee voted on patch set 5 V +1 11/14/25, 09:01
-
core-ci voted on patch set 4 V +1 11/14/25, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89667
-
core-ci voted on patch set 5 V +1 11/14/25, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89669
-
Benni Mack voted on patch set 5 CR +1 11/14/25, 09:29
-
Oliver Hader voted on patch set 5 CR +1 11/14/25, 12:26
-
Oliver Hader voted on patch set 5 V +1 11/14/25, 12:37
-
Oliver Hader voted on patch set 5 CR +2 V +2 11/14/25, 12:38
-
Oliver Hader merged patch set 6 11/14/25, 12:38
Breaking-108093-AddRespectSubmittedDataValueArgumentInPasswordViewHelper.rst:14