91623[FEATURE] Add attribute AsNonSchedulableCommand for "schedulable"
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Lina Wolf +1
-
Verified V +2 Done
- Georg Ringer +2
- Lina Wolf +1
- core-ci +1 CI
Issues 2
Files 29
- typo3/sysext/backend/Classes/Command/CreateBackendUserCommand.php+5 −0
- typo3/sysext/backend/Classes/Command/DebugBackendModulesCommand.php+2 −0
- typo3/sysext/backend/Classes/Command/DebugBackendRoutesCommand.php+2 −0
- typo3/sysext/backend/Classes/Command/ResetPasswordCommand.php+5 −0
- typo3/sysext/core/Classes/Attribute/AsNonSchedulableCommand.phpnew+29 −0
- typo3/sysext/core/Classes/Command/ExtensionListCommand.php+4 −0
- typo3/sysext/core/Classes/Command/SendEmailCommand.php1+4 −0
- typo3/sysext/core/Classes/Command/SetupExtensionsCommand.php+4 −0
- typo3/sysext/core/Classes/Command/SiteListCommand.php+4 −0
- typo3/sysext/core/Classes/Command/SiteSetsListCommand.php+4 −0
- typo3/sysext/core/Classes/Command/SiteShowCommand.php+4 −0
- typo3/sysext/core/Classes/Console/CommandRegistry.php+20 −0
- typo3/sysext/core/Configuration/Services.php+2 −1
- typo3/sysext/core/Configuration/Services.yaml+0 −38
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107151-AddAsNonSchedulableCommandAttribute.rstnew+49 −0
- typo3/sysext/core/Tests/Functional/DependencyInjection/AsCommandAttributeTest.php+21 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_schedulable_command/Classes/Command/NonSchedulableCommand.phpnew+34 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_schedulable_command/Classes/Command/SchedulableCommand.phpnew+32 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_schedulable_command/Configuration/Services.yamlnew+8 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_schedulable_command/composer.jsonnew+19 −0
Show 9 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_schedulable_command/ext_emconf.phpnew+21 −0
- typo3/sysext/lowlevel/Classes/Command/ListSysLogCommand.php+5 −0
- typo3/sysext/lowlevel/Classes/Command/TranslationDomainListCommand.php+4 −0
- typo3/sysext/lowlevel/Configuration/Services.yaml+0 −21
- typo3/sysext/scheduler/Classes/Command/SchedulerCommand.php+5 −0
- typo3/sysext/scheduler/Classes/Command/SchedulerExecuteCommand.php+5 −0
- typo3/sysext/scheduler/Classes/Command/SchedulerListCommand.php+5 −0
- typo3/sysext/scheduler/Configuration/Services.yaml+0 −21
- composer.json+1 −0
Review log 2027
Show 12 earlier messages
-
Garvin Hicking uploaded patch set 1 11/13/25, 15:28
-
core-ci voted on patch set 1 V +1 11/13/25, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89540
-
Lina Wolf commented on patch set 1 CR +1 V +1 11/13/25, 16:27
Wow, great stuff! Tested it with the commands in t3docs/example and it worked fine! The code looks good to me -
Lina Wolf commented on patch set 1 11/13/25, 16:31
Can be tested with https://github.com/TYPO3-Documentation/t3docs-examples/pull/322 -
Garvin Hicking commented on patch set 2
CR +1V +111/13/25, 16:34Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 11/13/25, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89549
-
Oli Bartsch commented on patch set 2 11/13/25, 17:03
Why not `#[NonSchedulableCommand]`? -
Stefan Bürk commented on patch set 2 11/13/25, 17:53
IMO it does not lack it. It was decision to have it that way, see discussion back than: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80404/comment/be25623e_5a4cdd26/ -
Garvin Hicking commented on patch set 2 11/13/25, 18:01
Reply
I'm happy to use an attribute, I will propose a parallel patch so we can choose between any of the implementations. I won't be able to do this before end of next week though.Reply
We mainly wanted to move forward with having the Attribute, despite its shortcomings. That was what I meant with "lacking". I appreciate pointing this out though, will reword this to be more precise. -
Garvin Hicking updated the commit message in patch set 3
V +111/13/25, 18:03 -
core-ci voted on patch set 3 V +1 11/13/25, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89561
-
Chris Müller updated the commit message in patch set 4
V +111/13/25, 20:12 -
core-ci voted on patch set 4 V +1 11/13/25, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89584
-
Garvin Hicking uploaded patch set 5
V +111/17/25, 08:06 -
core-ci voted on patch set 5 V +1 11/17/25, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89907
-
Garvin Hicking uploaded patch set 6
V +111/17/25, 08:15 -
Garvin Hicking commented on patch set 6 11/17/25, 08:18
Reply
Done -
core-ci voted on patch set 6 V +1 11/17/25, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89908
-
Lina Wolf commented on patch set 6 CR -1 11/19/25, 15:08
Working on it -
Lina Wolf uploaded patch set 7
CR -1V +111/19/25, 15:11 -
Lina Wolf voted on patch set 7 CR +1 V +1 11/19/25, 15:13
-
Garvin Hicking commented on patch set 7 11/19/25, 15:23
Reply
thanks! 😊 -
core-ci voted on patch set 7 V +1 11/19/25, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90158
-
Georg Ringer voted on patch set 7 CR +2 V +2 11/19/25, 20:04
-
Georg Ringer merged patch set 8 11/19/25, 20:04
-
Lina Wolf commented on patch set 8 12/01/25, 07:00
-
Markus Klein commented on patch set 8 07/29/26, 09:14
SendEmailCommand.php:40This is wrong, this was schedulable before! https://forge.typo3.org/issues/110317