Review main Ready for review Orphaned

91625[TASK] Reload table content elements when delimiter/enclosure changes

Andreas Nedbal CR 0 V -1 Easy +2 −0 updated 04/22/26, 10:30

Commit message

This change prevents user error, expecting both table settings to be
applied instantly when they are not.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/25/91625/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/25/91625/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 4

Issues 1

Files 1

Review log 79

  1. Andreas Nedbal uploaded patch set 1 11/13/25, 16:21

  2. core-ci voted on patch set 1 V +1 11/13/25, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89548

  3. Lina Wolf voted on patch set 1 CR +1 V +1 11/13/25, 19:02

  4. Oliver Hader commented on patch set 1 11/14/25, 12:25

    Hm... I was using `A|B|C` as `bodytext` content, using pipe `|` as delimiter → resulting in three columns `A`, `B´ and `C` However, when changing the delimiter to semicolon `;`, accepting the reload & save, I'm seeing `A|B|C` in just one column. Is there anything, I am missing here? I guess, the transition of the delimiter from `|` to `;` needs to be handled in the custom element.
  5. Lina Wolf commented on patch set 1 11/14/25, 15:07

    Reply

    This has been the situation before as well and would be a speparate task.
  6. Peter Kraume voted on patch set 1 CR +1 V +1 02/16/26, 13:13

  7. Peter Kraume commented on patch set 1 02/27/26, 07:33

    Reply Unresolved

    This patch solves only a part of the problems described in the Forge ticket since there is still an issue with the display in the backend. But that's only a JavaScript issue with the display. The values stored in the database are correct. The main issue is, that writeTableSyntaxToTextarea() does a wrong interpretation of the values from the database. But that needs someone with more JavaScript knowledge than me.
  8. Benni Mack updated the commit message in patch set 2 CR +1 V +1 04/22/26, 06:42

  9. core-ci voted on patch set 2 V -1 04/22/26, 10:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100770