Review 13.4 Merged

91630[TASK] Update phpstan/phpstan-phpunit to 2.0.8

Benjamin Franzke CR +2 V +2 Easy +15 −9 updated 11/13/25, 19:02

Commit message

PHPStan contains a bug [1] where ordering of intersections matter
for method calls, where the first matching method of an intersection
wins since 1.12.8.

This error was already exposed in our v12.4 branch some
time ago (and was fixed via #105559), but is now also
happending in main and 13.4 with the update to phpstan-phpunit
v2.0.8 (because phpstan-phpunit calls `ObjectType::isSuperTypeOf(…)`
which has side effects and changes intersection orderings,
that are invoked when phpstan-phpunit uses this utility method).

Since the bug is confirmed upstream we apply the same strategy as for
our 12.4 branch and add these errors as false positives to our baseline
for the time being.

Commands executed:
  composer require --dev phpstan/phpstan-phpunit:^2.0.8 -W
  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

[1] https://github.com/phpstan/phpstan/issues/11978

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benjamin Franzke uploaded patch set 1 11/13/25, 18:54

  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/13/25, 18:59

  3. core-ci voted on patch set 1 V +1 11/13/25, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89567

  4. Benjamin Franzke merged patch set 2 11/13/25, 19:02