Review 13.4 Merged

91632[BUGFIX] Render callout title markup only if title is not empty

Oliver Hader CR +2 V +2 Easy +1 −7 updated 11/13/25, 20:23

Commit message

Since the title is always a string, checking for NULL has no effect and
always fails unexpectedly. Instead, we now check for an empty string.
This avoids rendering the title markup with an empty title and
`margin-bottom`, avoiding the visual gap.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 11/13/25, 19:58

  2. core-ci voted on patch set 1 V +1 11/13/25, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89580

  3. Oliver Hader voted on patch set 1 CR +2 V +2 11/13/25, 20:23

  4. Oliver Hader merged patch set 2 11/13/25, 20:23