91652[!!!][TASK] Avoid $_GET / $_POST safety net
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Lina Wolf +1
-
Verified V +2 Done
- Benni Mack +2
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/Http/RequestHandler.php+4 −29
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-108113-Globals_GETAnd_POSTNotResetToCurrentRequestDataAnymore.rstnew+79 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+2 −27
- typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php+0 −3
- typo3/sysext/frontend/Classes/Middleware/ShortcutAndMountPointRedirect.php+3 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/AbstractEnhancerSiteRequestTestCase.php+0 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/PageTypeDecoratorTest.php+0 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkHandlingController.php+0 −1
Review log 1829
Show 24 earlier messages
-
Christian Kuhn uploaded patch set 1 11/13/25, 22:26
-
core-ci voted on patch set 1 V -1 11/13/25, 22:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89600
-
Christian Kuhn uploaded patch set 2
V -111/13/25, 22:57 -
core-ci voted on patch set 2 V -1 11/13/25, 23:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89603
-
Christian Kuhn uploaded patch set 3
V -111/13/25, 23:20 -
core-ci voted on patch set 3 V +1 11/13/25, 23:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89604
-
Christian Kuhn uploaded patch set 4
V +111/13/25, 23:41 -
Christian Kuhn uploaded patch set 5 11/13/25, 23:43
-
Christian Kuhn uploaded patch set 6 11/13/25, 23:45
-
core-ci voted on patch set 4 V +1 11/13/25, 23:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89606
-
core-ci voted on patch set 6 V -1 11/14/25, 00:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89608
-
core-ci voted on patch set 5 V -1 11/14/25, 00:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89607
-
Christian Kuhn uploaded patch set 7
V -111/14/25, 00:29 -
Christian Kuhn uploaded patch set 8 11/14/25, 00:35
-
Christian Kuhn uploaded patch set 9 11/14/25, 00:37
-
core-ci voted on patch set 7 V +1 11/14/25, 00:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89611
-
core-ci voted on patch set 8 V +1 11/14/25, 00:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89612
-
core-ci voted on patch set 9 V +1 11/14/25, 00:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89613
-
Christian Kuhn uploaded patch set 10
V +111/14/25, 01:21 -
core-ci voted on patch set 10 V +1 11/14/25, 01:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89616
-
Christian Kuhn updated the commit message in patch set 11
V +111/14/25, 01:31 -
core-ci voted on patch set 11 V +1 11/14/25, 01:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89617
-
Lina Wolf commented on patch set 11 11/14/25, 03:38
In the docs we mention this as a last resort to get the request in a context where it is not passed on: https://docs.typo3.org/permalink/t3coreapi:typo3-request-global-variable Do we have resolved all cases in which the request could previously not be resolved? -
Benni Mack commented on patch set 11 11/14/25, 06:49
For some context: I added this safety net in v9 to overcome values from TypoScript "getData = GP:my_get_var" etc. This wasn't fully solved in v10, but actually in v11/v12 when we added the ServerRequestInterface to a lot of parts (Extbase, VHs, UserFunctions as third parameter), which is why we can now safely remove it in v14.Reply
it is still available (see RequestHandler.php), the safety net for $_GET and $_POST (which are overridden and synced) are the only parts that have been removed. -
Lina Wolf commented on patch set 11 11/14/25, 06:52
Reply
Acknowledged -
Lina Wolf commented on patch set 11 CR +1 V +1 11/14/25, 06:53
Let us go for it then! -
Benni Mack voted on patch set 11 CR +2 V +2 11/14/25, 07:07
-
Benni Mack merged patch set 12 11/14/25, 07:07
-
Lina Wolf commented on patch set 12 12/31/25, 08:34
Unresolved