91655[FEATURE] Add QR Codes module
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 37
- Build/Sources/TypeScript/backend/element/qrcode-element.ts+1 −1
- Build/Sources/TypeScript/redirects/element/qrcode-modal-button.tsnew+75 −0
- Build/tests/playwright/e2e/recycler/recycler-module.spec.ts1+10 −5
- Build/tests/playwright/e2e/redirects/qrcode-module.spec.tsnew+66 −0
- Build/tests/playwright/e2e/redirects/redirects-module.spec.ts+4 −1
- typo3/sysext/backend/Configuration/Backend/Modules.php+12 −0
- typo3/sysext/backend/Resources/Private/Language/Modules/link_management.xlfnew+17 −0
- typo3/sysext/backend/Resources/Public/JavaScript/element/qrcode-element.js+1 −1
- typo3/sysext/core/Classes/Upgrades/UserPermissionsForRenamedModulesMigration.php2+1 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-107628-ImprovedBackendModuleNamingAndStructure.rst+23 −0
- typo3/sysext/core/Documentation/Changelog/14.1/Feature-107756-AddQRCodeModule.rstnew+39 −0
- typo3/sysext/install/Configuration/PermissionPreset/be_groups_advanced_editor.yaml+1 −1
- typo3/sysext/install/Tests/Functional/Service/Fixtures/CreateUserGroupsCommandModules.csv+1 −1
- typo3/sysext/redirects/Classes/Controller/ManagementController.php2+21 −39
- typo3/sysext/redirects/Classes/Controller/QrCodeModuleController.phpnew+155 −0
- typo3/sysext/redirects/Classes/EventListener/QrCodeNewDocHeaderButton.php4new+85 −0
- typo3/sysext/redirects/Classes/Form/Element/QrCodeElement.php1new+63 −0
- typo3/sysext/redirects/Classes/FormDataProvider/QrCodeSourceHostDataProvider.phpnew+41 −0
- typo3/sysext/redirects/Classes/FormDataProvider/ValuePickerItemDataProvider.php+10 −0
- typo3/sysext/redirects/Classes/Hooks/HandleNewQrCodeRecord.phpnew+43 −0
Show 17 more files
- typo3/sysext/redirects/Classes/Repository/Demand.php+1 −0
- typo3/sysext/redirects/Classes/Repository/RedirectRepository.php+18 −12
- typo3/sysext/redirects/Classes/Service/ModulePaginationService.phpnew+57 −0
- typo3/sysext/redirects/Configuration/Backend/Modules.php+21 −5
- typo3/sysext/redirects/Configuration/TCA/sys_redirect.php+27 −8
- typo3/sysext/redirects/Documentation/Setup/Index.rst+1 −1
- typo3/sysext/redirects/Resources/Private/Language/Modules/qrcodes.xlf1new+48 −0
- typo3/sysext/redirects/Resources/Private/Language/Modules/redirects.xlfrenamed+1 −1
- typo3/sysext/redirects/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/redirects/Resources/Private/Language/locallang_db.xlf+3 −0
- typo3/sysext/redirects/Resources/Private/Partials/Pagination.fluid.html+6 −6
- typo3/sysext/redirects/Resources/Private/Templates/Management/Overview.fluid.html+8 −12
- typo3/sysext/redirects/Resources/Private/Templates/QrCode/Overview.fluid.htmlnew+384 −0
- typo3/sysext/redirects/Resources/Public/JavaScript/element/qrcode-modal-button.jsnew+13 −0
- typo3/sysext/redirects/Tests/Functional/Controller/ManagementControllerTest.php+1 −1
- typo3/sysext/redirects/Tests/Unit/FormDataProvider/ValuePickerItemDataProviderTest.php+8 −3
- typo3/sysext/redirects/ext_localconf.php+18 −0
Review log 64101
Show 4676 earlier messages
-
Jochen Roth uploaded patch set 1 11/13/25, 23:21
-
Jochen Roth marked it work in progress 11/13/25, 23:23
-
core-ci voted on patch set 1 V -1 11/13/25, 23:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89605
-
Jochen Roth uploaded patch set 2 11/14/25, 00:01
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 2 V -1 11/14/25, 00:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89610
-
Oli Bartsch commented on patch set 2 11/14/25, 07:51
qrcode-modal.ts:24Please make this a web component and avoid those trigger classes.ManagementController.php:61Please use a dedicated controller for the new moduleQrCodeNewDocHeaderButton.php:31Please make this final readonly and add a short description what this listener is for.QrCodeNewDocHeaderButton.php:54what is this param for?DataHandlerQrCodeData.php:30so `is_string()` // starts:with('new') ? -
Jochen Roth uploaded patch set 3
V -111/14/25, 18:24 -
core-ci voted on patch set 3 V -1 11/14/25, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89710
-
Jochen Roth rebased onto patch set 4
V -111/14/25, 20:26 -
Jochen Roth uploaded patch set 5 11/14/25, 20:33
-
core-ci voted on patch set 4 V -1 11/14/25, 20:44 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 5 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89725
-
core-ci voted on patch set 5 V -1 11/14/25, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89726
-
Jochen Roth uploaded patch set 6
V -111/14/25, 21:17 -
Jochen Roth uploaded patch set 7 11/14/25, 21:21
-
Jochen Roth uploaded patch set 8 11/14/25, 21:26
-
core-ci voted on patch set 6 V -1 11/14/25, 21:36 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 7 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89729
-
core-ci voted on patch set 7 V -1 11/14/25, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89730
-
core-ci voted on patch set 8 V -1 11/14/25, 21:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89733
-
Jochen Roth uploaded patch set 9
V -111/15/25, 09:49 -
core-ci voted on patch set 9 V -1 11/15/25, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89778
-
Jochen Roth uploaded patch set 10
V -111/15/25, 10:25 -
core-ci voted on patch set 10 V -1 11/15/25, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89780
-
Jochen Roth uploaded patch set 11
V -111/15/25, 13:34 -
Jochen Roth uploaded patch set 12 11/15/25, 13:37
-
Jochen Roth uploaded patch set 13 11/15/25, 13:39
-
core-ci voted on patch set 11 V -1 11/15/25, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89795
-
core-ci voted on patch set 12 V -1 11/15/25, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89796
-
core-ci voted on patch set 13 V +1 11/15/25, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89797
-
Jochen Roth uploaded patch set 14
V +111/15/25, 15:59 -
Jochen Roth uploaded patch set 15 11/15/25, 16:06
-
core-ci voted on patch set 14 V -1 11/15/25, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89805
-
Jochen Roth uploaded patch set 16 11/15/25, 16:13
-
core-ci voted on patch set 15 V -1 11/15/25, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89807
-
core-ci voted on patch set 16 V +1 11/15/25, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89809
-
Jochen Roth uploaded patch set 17
V +111/16/25, 12:05 -
core-ci voted on patch set 17 V +1 11/16/25, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89856
-
Jochen Roth marked it ready for review 11/16/25, 12:24
-
Jochen Roth commented on patch set 17 11/16/25, 12:25
qrcode-modal.ts:24ReplyDoneManagementController.php:61ReplyDoneQrCodeNewDocHeaderButton.php:31ReplyDoneQrCodeNewDocHeaderButton.php:54ReplyThis params makes sure the "New" button in form engine picks the right TCA type. Otherwise it will fall back to "default" instead of "qrcodes"DataHandlerQrCodeData.php:30ReplyDone -
Jochen Roth uploaded patch set 18
V +111/16/25, 12:27 -
Jochen Roth uploaded patch set 19 11/16/25, 12:31
-
core-ci voted on patch set 18 V +1 11/16/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89857
-
core-ci voted on patch set 19 V +1 11/16/25, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89858
-
Lina Wolf commented on patch set 19 11/16/25, 13:00
Trying it out, I get offered for the "Source domain" only "localhost" even though I have a site with a ddev domain defined. What exactly is "Source domain" and what should it contain? When I create the the QR code and try to open it, it creates a link going to "localhost" -
Jochen Roth commented on patch set 19 11/16/25, 17:59
Reply
You should see all domains configured in all Sites See`ValuePickerItemDataProvider.php:getHosts()` for details. -
Georg Ringer commented on patch set 19 11/16/25, 20:16
- can we have access fields like hidden as well? - the source_host behaves different and I don't see a reason for that: * is not available, after creating a qr code, the host can't be edited -
Lina Wolf commented on patch set 19 11/17/25, 08:09
Reply
I do have several sites defined: two valid ones and several outdated ones. However only "localhost" is displayed. I can give you my configuration if theat is helpful -
Lina Wolf commented on patch set 19 11/17/25, 08:11
Reply
It makes sense, that the host cant be edited: The QR code is going on that domain, so editing it would produce a new QR code which is not possible once it is published / printed. Doing so would create a completely new QR code Speaking of which, using the hidden field to decide if the QR code is published is probably a good idea -
Jochen Roth commented on patch set 19 CR -1 11/17/25, 08:19
Reply
IMO, the concept of QR Code is not to be edited. Because once it is printed or handed out to whoever, it has static data. e.g. when you create a QR Code with the URL https://example.com/_some/redirect it can't be changed unless you want to break the QR Code. When it comes to the asterisk ('*'), you don't want a QR Code with a static link to "https://*/_some/redirect". That won't work. I'll update the feature rst ro reflect this behaviour. -
Jochen Roth updated the commit message in patch set 20
CR -1V +111/17/25, 08:50 -
Jochen Roth voted on patch set 20 CR -1 11/17/25, 08:52
-
core-ci voted on patch set 20 V +1 11/17/25, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89920
-
Jochen Roth uploaded patch set 21
CR -1V +111/17/25, 12:55 -
Georg Ringer commented on patch set 21 11/17/25, 13:01
IMO we really just use a warning but not blocking to be able to edit the host. typical usecase: same for QR as for regular redirects: working on a preview domain and then production is used => now a different domain. -
Lina Wolf commented on patch set 21 11/17/25, 13:03
Reply
I think displaying a warning on changing a non-hidden QR code would be a good idea. I don't think we have a TCA tool for that however? -
core-ci voted on patch set 21 V +1 11/17/25, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89940
-
Jochen Roth updated the commit message in patch set 22
V +111/18/25, 11:25 -
core-ci voted on patch set 22 V +1 11/18/25, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90012
-
Jochen Roth commented on patch set 22 11/18/25, 13:06
Reply
Seems like an issue when base url das not contain a domain, only a path. -
Jochen Roth commented on patch set 22 11/18/25, 13:08
This feature will be delayed. Not going to make it into 14.0 - Planned for 14.1 -
Jochen Roth uploaded patch set 23
V +112/03/25, 11:28 -
Jochen Roth uploaded patch set 24 12/03/25, 11:31
-
core-ci voted on patch set 23 V -1 12/03/25, 11:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91517
-
core-ci voted on patch set 24 V -1 12/03/25, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91519
-
Jochen Roth uploaded patch set 25
V -112/03/25, 12:03 -
Jochen Roth uploaded patch set 26 12/03/25, 12:04
-
Jochen Roth uploaded patch set 27 12/03/25, 12:04
-
core-ci voted on patch set 26 V +1 12/03/25, 12:16 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 27 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91526
-
core-ci voted on patch set 25 V +1 12/03/25, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91525
-
core-ci voted on patch set 27 V +1 12/03/25, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91527
-
Jochen Roth uploaded patch set 28
V +112/03/25, 12:24 -
Jochen Roth uploaded patch set 29 12/03/25, 12:26
-
Jochen Roth uploaded patch set 30 12/03/25, 12:26
-
core-ci voted on patch set 28 V +1 12/03/25, 12:35 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 29, 30 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91529
-
core-ci voted on patch set 29 V +1 12/03/25, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91531
-
core-ci voted on patch set 30 V +1 12/03/25, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91532
-
Jochen Roth commented on patch set 30 12/03/25, 12:51
recycler-module.spec.ts:12Properly wait for the formEngine. With the new tests in place this test became flaky.
-
Jochen Roth uploaded patch set 31
V +112/03/25, 12:58 -
core-ci voted on patch set 31 V +1 12/03/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91535
-
Jochen Roth uploaded patch set 32
V +112/03/25, 13:38 -
core-ci voted on patch set 32 V +1 12/03/25, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91536
-
Guido Schmechel commented on patch set 32 12/03/25, 16:10
We tested the module today and think it's really cool. What we wondered was: Does it make sense to hide the module in all contexts except production? Or perhaps add a note? Our concern is that staging QR codes might suddenly be sent or even printed out. -
Georg Ringer voted on patch set 32 CR +1 V +1 12/03/25, 20:25
-
Oli Bartsch commented on patch set 32 V -1 12/04/25, 09:08
Will review -
Oli Bartsch uploaded patch set 33
CR +1V +112/04/25, 12:41 -
core-ci voted on patch set 33 V -1 12/04/25, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91588
-
Oli Bartsch uploaded patch set 34
V -112/04/25, 16:42 -
core-ci voted on patch set 34 V -1 12/04/25, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91595
-
Oli Bartsch uploaded patch set 35
V -112/04/25, 17:03 -
core-ci voted on patch set 35 V -1 12/04/25, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91596
-
Oli Bartsch uploaded patch set 36
V -112/04/25, 20:34 -
core-ci voted on patch set 36 V +1 12/04/25, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91610
-
Oli Bartsch commented on patch set 36 CR +1 V +1 12/04/25, 22:19
Reply
Done -
Oli Bartsch uploaded patch set 37
CR +1V +112/04/25, 22:27 -
Oli Bartsch voted on patch set 37 CR +1 V +1 12/04/25, 22:27
-
core-ci voted on patch set 37 V +1 12/04/25, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91617
-
Garvin Hicking commented on patch set 37 CR +1 V +1 12/05/25, 11:37
Awesome! No problems for me :)qrcodes.xlf:6mixed tab/space, but will be covered in followups https://review.typo3.org/c/Packages/TYPO3.CMS/+/91368 -
Oli Bartsch voted on patch set 37 CR +2 V +2 12/05/25, 11:38
-
Oli Bartsch merged patch set 38 12/05/25, 11:38
-
Simon Schaufelberger commented on patch set 38 12/05/25, 11:49
QrCodeElement.php:51UnresolvedThis breaks for me as on my local dev environment. I don't use https. why is this even hard coded? -
Benjamin Franzke commented on patch set 38 12/05/25, 14:34
UserPermissionsForRenamedModulesMigration.php:43Users will also need to be migrated to have access to `link_management` as the module was moved to a new parent, right? -
Oli Bartsch commented on patch set 38 12/09/25, 17:44
UserPermissionsForRenamedModulesMigration.php:43ReplyYes you're right. Thanks! I've extended the migration: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92072