Review main Merged

91655[FEATURE] Add QR Codes module

Jochen Roth CR +2 V +2 Expert +1287 −98 updated 12/09/25, 17:44

Commit message

A new backend module called "QR Codes" has been added.
The "Redirects" and "QR Codes" module are now submodules
of "Link Management".

The new module leverages the existing logic of the
"Redirects" but uses a custom TCA type to adapt the GUI
for the QR Codes.

It enables the user to create and download a QR Code in
different sizes and formats (PNG, SVG).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 37

Show 17 more files

Review log 64101

Show 4676 earlier messages
  1. Jochen Roth uploaded patch set 1 11/13/25, 23:21

  2. Jochen Roth marked it work in progress 11/13/25, 23:23

  3. core-ci voted on patch set 1 V -1 11/13/25, 23:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89605

  4. Jochen Roth uploaded patch set 2 11/14/25, 00:01

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  5. core-ci voted on patch set 2 V -1 11/14/25, 00:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89610

  6. Oli Bartsch commented on patch set 2 11/14/25, 07:51

    qrcode-modal.ts:24

    Please make this a web component and avoid those trigger classes.

    ManagementController.php:61

    Please use a dedicated controller for the new module

    QrCodeNewDocHeaderButton.php:31

    Please make this final readonly and add a short description what this listener is for.

    QrCodeNewDocHeaderButton.php:54

    what is this param for?

    DataHandlerQrCodeData.php:30

    so `is_string()` // starts:with('new') ?
  7. Jochen Roth uploaded patch set 3 V -1 11/14/25, 18:24

  8. core-ci voted on patch set 3 V -1 11/14/25, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89710

  9. Jochen Roth rebased onto patch set 4 V -1 11/14/25, 20:26

  10. Jochen Roth uploaded patch set 5 11/14/25, 20:33

  11. core-ci voted on patch set 4 V -1 11/14/25, 20:44 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 5 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89725

  12. core-ci voted on patch set 5 V -1 11/14/25, 20:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89726

  13. Jochen Roth uploaded patch set 6 V -1 11/14/25, 21:17

  14. Jochen Roth uploaded patch set 7 11/14/25, 21:21

  15. Jochen Roth uploaded patch set 8 11/14/25, 21:26

  16. core-ci voted on patch set 6 V -1 11/14/25, 21:36 Copied votes on follow-up patch sets have been updated: * Verified-1 has been copied to patch set 7 (copy condition: "changekind:NO_CHANGE"). Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89729

  17. core-ci voted on patch set 7 V -1 11/14/25, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89730

  18. core-ci voted on patch set 8 V -1 11/14/25, 21:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89733

  19. Jochen Roth uploaded patch set 9 V -1 11/15/25, 09:49

  20. core-ci voted on patch set 9 V -1 11/15/25, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89778

  21. Jochen Roth uploaded patch set 10 V -1 11/15/25, 10:25

  22. core-ci voted on patch set 10 V -1 11/15/25, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89780

  23. Jochen Roth uploaded patch set 11 V -1 11/15/25, 13:34

  24. Jochen Roth uploaded patch set 12 11/15/25, 13:37

  25. Jochen Roth uploaded patch set 13 11/15/25, 13:39

  26. core-ci voted on patch set 11 V -1 11/15/25, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89795

  27. core-ci voted on patch set 12 V -1 11/15/25, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89796

  28. core-ci voted on patch set 13 V +1 11/15/25, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89797

  29. Jochen Roth uploaded patch set 14 V +1 11/15/25, 15:59

  30. Jochen Roth uploaded patch set 15 11/15/25, 16:06

  31. core-ci voted on patch set 14 V -1 11/15/25, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89805

  32. Jochen Roth uploaded patch set 16 11/15/25, 16:13

  33. core-ci voted on patch set 15 V -1 11/15/25, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89807

  34. core-ci voted on patch set 16 V +1 11/15/25, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89809

  35. Jochen Roth uploaded patch set 17 V +1 11/16/25, 12:05

  36. core-ci voted on patch set 17 V +1 11/16/25, 12:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89856

  37. Jochen Roth marked it ready for review 11/16/25, 12:24

  38. Jochen Roth commented on patch set 17 11/16/25, 12:25

    qrcode-modal.ts:24 Reply

    Done

    ManagementController.php:61 Reply

    Done

    QrCodeNewDocHeaderButton.php:31 Reply

    Done

    QrCodeNewDocHeaderButton.php:54 Reply

    This params makes sure the "New" button in form engine picks the right TCA type. Otherwise it will fall back to "default" instead of "qrcodes"

    DataHandlerQrCodeData.php:30 Reply

    Done
  39. Jochen Roth uploaded patch set 18 V +1 11/16/25, 12:27

  40. Jochen Roth uploaded patch set 19 11/16/25, 12:31

  41. core-ci voted on patch set 18 V +1 11/16/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89857

  42. core-ci voted on patch set 19 V +1 11/16/25, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89858

  43. Lina Wolf commented on patch set 19 11/16/25, 13:00

    Trying it out, I get offered for the "Source domain" only "localhost" even though I have a site with a ddev domain defined. What exactly is "Source domain" and what should it contain? When I create the the QR code and try to open it, it creates a link going to "localhost"
  44. Jochen Roth commented on patch set 19 11/16/25, 17:59

    Reply

    You should see all domains configured in all Sites See`ValuePickerItemDataProvider.php:getHosts()` for details.
  45. Georg Ringer commented on patch set 19 11/16/25, 20:16

    - can we have access fields like hidden as well? - the source_host behaves different and I don't see a reason for that: * is not available, after creating a qr code, the host can't be edited
  46. Lina Wolf commented on patch set 19 11/17/25, 08:09

    Reply

    I do have several sites defined: two valid ones and several outdated ones. However only "localhost" is displayed. I can give you my configuration if theat is helpful
  47. Lina Wolf commented on patch set 19 11/17/25, 08:11

    Reply

    It makes sense, that the host cant be edited: The QR code is going on that domain, so editing it would produce a new QR code which is not possible once it is published / printed. Doing so would create a completely new QR code Speaking of which, using the hidden field to decide if the QR code is published is probably a good idea
  48. Jochen Roth commented on patch set 19 CR -1 11/17/25, 08:19

    Reply

    IMO, the concept of QR Code is not to be edited. Because once it is printed or handed out to whoever, it has static data. e.g. when you create a QR Code with the URL https://example.com/_some/redirect it can't be changed unless you want to break the QR Code. When it comes to the asterisk ('*'), you don't want a QR Code with a static link to "https://*/_some/redirect";. That won't work. I'll update the feature rst ro reflect this behaviour.
  49. Jochen Roth updated the commit message in patch set 20 CR -1 V +1 11/17/25, 08:50

  50. Jochen Roth voted on patch set 20 CR -1 11/17/25, 08:52

  51. core-ci voted on patch set 20 V +1 11/17/25, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89920

  52. Jochen Roth uploaded patch set 21 CR -1 V +1 11/17/25, 12:55

  53. Georg Ringer commented on patch set 21 11/17/25, 13:01

    IMO we really just use a warning but not blocking to be able to edit the host. typical usecase: same for QR as for regular redirects: working on a preview domain and then production is used => now a different domain.
  54. Lina Wolf commented on patch set 21 11/17/25, 13:03

    Reply

    I think displaying a warning on changing a non-hidden QR code would be a good idea. I don't think we have a TCA tool for that however?
  55. core-ci voted on patch set 21 V +1 11/17/25, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89940

  56. Jochen Roth updated the commit message in patch set 22 V +1 11/18/25, 11:25

  57. core-ci voted on patch set 22 V +1 11/18/25, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90012

  58. Jochen Roth commented on patch set 22 11/18/25, 13:06

    Reply

    Seems like an issue when base url das not contain a domain, only a path.
  59. Jochen Roth commented on patch set 22 11/18/25, 13:08

    This feature will be delayed. Not going to make it into 14.0 - Planned for 14.1
  60. Jochen Roth uploaded patch set 23 V +1 12/03/25, 11:28

  61. Jochen Roth uploaded patch set 24 12/03/25, 11:31

  62. core-ci voted on patch set 23 V -1 12/03/25, 11:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91517

  63. core-ci voted on patch set 24 V -1 12/03/25, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91519

  64. Jochen Roth uploaded patch set 25 V -1 12/03/25, 12:03

  65. Jochen Roth uploaded patch set 26 12/03/25, 12:04

  66. Jochen Roth uploaded patch set 27 12/03/25, 12:04

  67. core-ci voted on patch set 26 V +1 12/03/25, 12:16 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 27 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91526

  68. core-ci voted on patch set 25 V +1 12/03/25, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91525

  69. core-ci voted on patch set 27 V +1 12/03/25, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91527

  70. Jochen Roth uploaded patch set 28 V +1 12/03/25, 12:24

  71. Jochen Roth uploaded patch set 29 12/03/25, 12:26

  72. Jochen Roth uploaded patch set 30 12/03/25, 12:26

  73. core-ci voted on patch set 28 V +1 12/03/25, 12:35 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 29, 30 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91529

  74. core-ci voted on patch set 29 V +1 12/03/25, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91531

  75. core-ci voted on patch set 30 V +1 12/03/25, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91532

  76. Jochen Roth commented on patch set 30 12/03/25, 12:51

    recycler-module.spec.ts:12

    Properly wait for the formEngine. With the new tests in place this test became flaky.
  1. Jochen Roth uploaded patch set 31 V +1 12/03/25, 12:58

  2. core-ci voted on patch set 31 V +1 12/03/25, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91535

  3. Jochen Roth uploaded patch set 32 V +1 12/03/25, 13:38

  4. core-ci voted on patch set 32 V +1 12/03/25, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91536

  5. Guido Schmechel commented on patch set 32 12/03/25, 16:10

    We tested the module today and think it's really cool. What we wondered was: Does it make sense to hide the module in all contexts except production? Or perhaps add a note? Our concern is that staging QR codes might suddenly be sent or even printed out.
  6. Georg Ringer voted on patch set 32 CR +1 V +1 12/03/25, 20:25

  7. Oli Bartsch commented on patch set 32 V -1 12/04/25, 09:08

    Will review
  8. Oli Bartsch uploaded patch set 33 CR +1 V +1 12/04/25, 12:41

  9. core-ci voted on patch set 33 V -1 12/04/25, 12:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91588

  10. Oli Bartsch uploaded patch set 34 V -1 12/04/25, 16:42

  11. core-ci voted on patch set 34 V -1 12/04/25, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91595

  12. Oli Bartsch uploaded patch set 35 V -1 12/04/25, 17:03

  13. core-ci voted on patch set 35 V -1 12/04/25, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91596

  14. Oli Bartsch uploaded patch set 36 V -1 12/04/25, 20:34

  15. core-ci voted on patch set 36 V +1 12/04/25, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91610

  16. Oli Bartsch commented on patch set 36 CR +1 V +1 12/04/25, 22:19

    Reply

    Done
  17. Oli Bartsch uploaded patch set 37 CR +1 V +1 12/04/25, 22:27

  18. Oli Bartsch voted on patch set 37 CR +1 V +1 12/04/25, 22:27

  19. core-ci voted on patch set 37 V +1 12/04/25, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91617

  20. Garvin Hicking commented on patch set 37 CR +1 V +1 12/05/25, 11:37

    Awesome! No problems for me :)

    qrcodes.xlf:6

    mixed tab/space, but will be covered in followups https://review.typo3.org/c/Packages/TYPO3.CMS/+/91368
  21. Oli Bartsch voted on patch set 37 CR +2 V +2 12/05/25, 11:38

  22. Oli Bartsch merged patch set 38 12/05/25, 11:38

  23. Simon Schaufelberger commented on patch set 38 12/05/25, 11:49

    QrCodeElement.php:51 Unresolved

    This breaks for me as on my local dev environment. I don't use https. why is this even hard coded?
  24. Benjamin Franzke commented on patch set 38 12/05/25, 14:34

    UserPermissionsForRenamedModulesMigration.php:43

    Users will also need to be migrated to have access to `link_management` as the module was moved to a new parent, right?
  25. Oli Bartsch commented on patch set 38 12/09/25, 17:44

    UserPermissionsForRenamedModulesMigration.php:43 Reply

    Yes you're right. Thanks! I've extended the migration: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92072