Review main Merged Breaking

91656[!!!][TASK] Avoid global content link rewriting in FE

Christian Kuhn CR +2 V +2 Normal +59 −41 updated 11/14/25, 10:20

Commit message

The frontend rendering contains a method that receives
the fully generated Response body content to apply a
global search and replace string operation in order
to fix links to included assets.

This was always a bad idea and is now finally obsolete
with the new system resource API: The system can expect
that links to resources are final when they are created
by some sub system.

The patch removes the logic along with a TYPO3_CONF_VARS
setting that allowed exending this brittle magic.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 914

  1. Christian Kuhn uploaded patch set 1 11/14/25, 01:44

  2. core-ci voted on patch set 1 V +1 11/14/25, 01:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89619

  3. Christian Kuhn uploaded patch set 2 V +1 11/14/25, 01:52

  4. core-ci voted on patch set 2 V +1 11/14/25, 01:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89620

  5. Christian Kuhn uploaded patch set 3 V +1 11/14/25, 02:17

  6. Christian Kuhn updated the commit message in patch set 4 11/14/25, 02:18

  7. Christian Kuhn uploaded patch set 5 11/14/25, 02:20

  8. core-ci voted on patch set 3 V +1 11/14/25, 02:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89622

  9. core-ci voted on patch set 4 V +1 11/14/25, 02:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89623

  10. core-ci voted on patch set 5 V +1 11/14/25, 02:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89624

  11. Lina Wolf commented on patch set 5 CR +1 V +1 11/14/25, 03:32

    This change might be hurtful for some who are reliying on it, I have, however never seen a project actually use this. We might want to add some examples on how to solve issues using the new System Resource API in the aftermath. Another step in the direction on getting rid of the TypoScriptFrontendController! Yeah!
  12. Helmut Hummel voted on patch set 5 CR +1 V +1 11/14/25, 07:39

  13. Christian Kuhn voted on patch set 5 CR +2 V +2 11/14/25, 10:20

  14. Christian Kuhn merged patch set 6 11/14/25, 10:20