91662[FEATURE] Register row updaters via PHP attribute
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Wouter Wolters +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 17
- typo3/sysext/core/Classes/Attribute/AsRowUpdater.phpnew+32 −0
- typo3/sysext/core/Classes/Service/RowUpdaterService.php2new+63 −0
- typo3/sysext/core/Classes/Service/UpgradeWizardsService.php+25 −22
- typo3/sysext/core/Classes/Upgrades/RowUpdater/RowUpdaterRegistry.phpnew+77 −0
- typo3/sysext/core/Classes/Upgrades/DatabaseRowsUpdateWizard.php+32 −58
- typo3/sysext/core/Configuration/Services.php+8 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-110269-AllowRowUpdaterRegistrationViaPhpAttribute.rstnew+97 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_rowupdater/Classes/Service/InjectionTestService.phpnew+34 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_rowupdater/Classes/Upgrades/RowUpdater/AttributeIdentifier.phpnew+58 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_rowupdater/Classes/Upgrades/RowUpdater/AttributeNoIdentifier.phpnew+58 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_rowupdater/Classes/Upgrades/RowUpdater/ManualIdentifier.phpnew+56 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_rowupdater/Classes/Upgrades/RowUpdater/ManualNoIdentifier.phpnew+56 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_rowupdater/Configuration/Services.yamlnew+17 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_rowupdater/composer.jsonnew+23 −0
- typo3/sysext/core/Tests/Functional/Upgrades/RowUpdater/RowUpdaterRegistryTest.phpnew+105 −0
- typo3/sysext/install/Classes/Service/SetupDatabaseService.php+3 −3
- composer.json+1 −0
Review log 2643
Show 918 earlier messages
-
Stefan Bürk uploaded patch set 1 11/14/25, 08:26
-
core-ci voted on patch set 1 V -1 11/14/25, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89665
-
Stefan Bürk uploaded patch set 2
V -111/14/25, 14:23 -
core-ci voted on patch set 2 V -1 11/14/25, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89693
-
Stefan Bürk uploaded patch set 3
V -111/14/25, 19:49 -
core-ci voted on patch set 3 V -1 11/14/25, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89720
-
Stefan Bürk uploaded patch set 4
V -111/14/25, 21:08 -
core-ci voted on patch set 4 V -1 11/14/25, 21:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89728
-
Stefan Bürk uploaded patch set 5
V -111/14/25, 21:23 -
core-ci voted on patch set 5 V -1 11/14/25, 21:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89731
-
Stefan Bürk uploaded patch set 6
V -111/14/25, 21:38 -
core-ci voted on patch set 6 V +1 11/14/25, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89734
-
Stefan Bürk uploaded patch set 7
V +111/24/25, 15:54 -
Stefan Bürk rebased onto patch set 8 11/24/25, 15:57
-
core-ci voted on patch set 7 V -1 11/24/25, 16:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90867
-
core-ci voted on patch set 8 V +1 11/24/25, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90870
-
Stefan Bürk rebased onto patch set 9
V +111/24/25, 17:55 -
core-ci voted on patch set 9 V +1 11/24/25, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90883
-
Stefan Bürk rebased onto patch set 10
V +111/24/25, 18:54 -
core-ci voted on patch set 10 V +1 11/24/25, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90890
-
Stefan Bürk uploaded patch set 11
V +107/22/26, 17:07 -
core-ci voted on patch set 11 V -1 07/22/26, 17:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105195
-
Stefan Bürk uploaded patch set 12
V -107/22/26, 17:47 -
core-ci voted on patch set 12 V +1 07/22/26, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105196
-
Benni Mack voted on patch set 12 CR +1 07/22/26, 20:49
-
Benni Mack uploaded patch set 13
CR +1V +108/06/26, 12:58 -
core-ci voted on patch set 13 V +1 08/06/26, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106000
-
Stefan Bürk uploaded patch set 14
V +108/14/26, 07:24 -
core-ci voted on patch set 14 V +1 08/14/26, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106694
-
Stefan Bürk rebased onto patch set 15
V +108/14/26, 13:53 -
core-ci voted on patch set 15 V +1 08/14/26, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106706
-
Oliver Klee voted on patch set 15 V +1 08/14/26, 14:26
-
Stefan Bürk rebased onto patch set 16
V +108/14/26, 18:29 -
core-ci voted on patch set 16 V +1 08/14/26, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106712
-
Benni Mack commented on patch set 16 08/15/26, 06:50
-
Stefan Bürk uploaded patch set 17
V +108/16/26, 00:29 -
Stefan Bürk commented on patch set 16 08/16/26, 00:30
PS17 addresses the remark on `RowUpdaterService` (details in that thread). `#[Autoconfigure(public: true)]` is removed from both `RowUpdaterService` and `RowUpdaterRegistry`. `SetupDatabaseService::markWizardsDone()` no longer fetches `RowUpdaterService` from the container, it asks the already fetched `UpgradeWizardsService` for the identifiers through the new `getAllRowUpdaterIdentifiers()`. `RowUpdaterService::getAvailableRowUpdater()` is dropped, it had no other caller. Worth flagging for reviewers: `markWizardsDone()` has no unit or functional coverage at all, so a wrongly private service stays green in phpunit and only surfaces in the installer. Verified locally beyond the usual gates: `e2e-install` on sqlite and mariadb, which drives the real web installer, and the full `e2e` suite, whose prepare step runs `vendor/bin/typo3 setup` and therefore covers the second `markWizardsDone()` caller. Also green: cgl, cglHeaderGit, phpstan, checkIntegrityPhp, and functional on sqlite + mariadb for `core/Tests/Functional/Upgrades` and `install/Tests/Functional`.RowUpdaterService.php:32ReplyGood catch — and the answer is "no", at least not the way it was done here. Addressed in PS17. `RowUpdaterService` had to be public only because `SetupDatabaseService::markWizardsDone()` pulls it out of the container directly. That `$container->get()` itself cannot become constructor injection: the container handed into `markWizardsDone()` is the late-booted, non-failsafe one from `BootService::loadExtLocalconfDatabase()`, deliberately *not* the failsafe install tool container that built `SetupDatabaseService` — the list has to come from the container that already knows the extensions activated during setup. That is also why `UpgradeWizardsService` carries the same attribute in existing code. The second container fetch can be avoided entirely though. `markWizardsDone()` already fetches `UpgradeWizardsService` one line above, and that service already has `RowUpdaterRegistry` injected and already owns the other row updater listings (`listOfRowUpdatersDone()`, `getWizardInformation()`, `assertIdentifierIsValid()`). So the lookup moved there as `getAllRowUpdaterIdentifiers()`, symmetric to `getNonRepeatableUpgradeWizards()` right above it. With that, `#[Autoconfigure(public: true)]` is gone from **both** `RowUpdaterService` and `RowUpdaterRegistry`. The registry never needed it in the first place — nothing fetched it from the container, and the functional test reaches it through the testing framework private container fallback. `RowUpdaterService::getAvailableRowUpdater()` is dropped as well, its only caller was that line. -
Stefan Bürk commented on patch set 17 1 comment 08/16/26, 00:30
-
core-ci voted on patch set 17 V +1 08/16/26, 00:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106770
-
Benni Mack voted on patch set 17 CR +1 V +1 08/31/26, 17:19
-
Wouter Wolters voted on patch set 17 CR +1 V +1 08/31/26, 20:52
-
Stefan Bürk voted on patch set 17 CR +2 V +2 08/31/26, 21:27
-
Stefan Bürk merged patch set 18 08/31/26, 21:27
RowUpdaterService.php:32