Review main Abandoned

9167[FEATURE] make pi_wrapInBaseClass wraps configurable

Stefan Galinski CR 0 V 0 Normal +64 −22 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 7

  1. Stefan Galinski commented on patch set 1 06/07/12, 17:33

    Hi Sebastian, Can you come up with a new patchset for your proposed changes please? Thanks in advance!
  2. Stefan Galinski commented on patch set 1 06/07/12, 17:33

    I didn't wrote or tested this patch. Just uploaded this one in the name of Steffen Müller. Seems like it was discussed on the old core mailing list a year ago!?
  3. Georg Ringer commented on patch set 1 06/07/12, 17:33

    just abandon it, extbase is current number one choice ... but IMO
  4. Georg Ringer commented on patch set 1 06/07/12, 17:33

    thats why I didnt give a -1 but of course you can review it still ;)
  5. Sebastian Michaelsen commented on patch set 1 06/07/12, 17:33

    @Georg: Disagree. There are still a lot of important pibased extensions out there that will be instantly improved by that feature.
  6. Sebastian Michaelsen commented on patch set 1 06/07/12, 17:33

    I would prefer that you didn't submit this As I see it from the code the new propeties are used like this: # Disable plugin wraps globally config.pluginWrap = 0 # Enables plugin wraps if the plugin is not(!) empty config.pluginWrap = ifEmpty # Enable plugin wrap for xyz plugin plugin.xyz.pluginWrap = 1 # Define a wrap layout for xyz plugin plugin.xyz.pluginWrap.wrap = <div class="plugin">|</div> plugin.xyz.pluginWrap.prepend = TEXT plugin.xyz.pluginWrap.prepend.value = <!-- a plugin --> I'm not happy with this. 1. "pluginWrap = ifEmpty" is misleading, as it does exactly the opposite as it says 2. pluginWrap (int/"ifEmpty") doesn't support stdWrap I think a better structure would be: plugin.xyz.pluginWrap { enable = 1 stdWrap { wrap = <div>|</div> if.isTrue.current = 1 } } * .enable would support stdWrap properties * .stdWrap parses the plugin content * with .stdWrap.if you can avoid wrapping if the plugin content is empty
  7. Stefan Galinski commented on patch set 1 06/07/12, 17:33

    Abandoned Seems that nobody is really interested in this one. If anyone wants to improve this one, he should come up with a new review request. Don't forget to take care about the notes in this request.