91670[TASK] Have dependency injection in ContentObjectRenderer
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 45
- Build/phpstan/phpstan-baseline.neon+0 −60
- typo3/sysext/core/Classes/Configuration/Features.php+6 −5
- typo3/sysext/core/Classes/Html/HtmlCropper.php+7 −5
- typo3/sysext/core/Classes/Html/HtmlParser.php+1 −1
- typo3/sysext/core/Classes/Html/SanitizerBuilderFactory.php+5 −22
- typo3/sysext/core/Classes/SystemResource/Publishing/SystemResourcePublisherInterface.php+0 −1
- typo3/sysext/core/Classes/Text/TextCropper.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TypoScriptService.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/HtmlCropperTest.php+5 −34
- typo3/sysext/core/Tests/Unit/Text/TextCropperTest.php+6 −36
- typo3/sysext/extbase/Classes/ContentObject/ExtbasePluginContentObject.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Configuration/FrontendConfigurationManagerTest.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Mvc/Web/Routing/UriBuilderTest.phpnew+48 −0
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+0 −20
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php+8 −10
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/ImageViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/ImageViewHelperTest.php+1 −1
- typo3/sysext/form/Tests/Functional/Controller/FormFrontendControllerTest.php+3 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectArrayInternalContentObject.php+1 −1
Show 25 more files
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+367 −677
- typo3/sysext/frontend/Classes/ContentObject/UserInternalContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+9 −11
- typo3/sysext/frontend/Classes/Typolink/LinkFactory.php+8 −9
- typo3/sysext/frontend/Classes/Typolink/LinkVarsCalculator.php+1 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/CaseContentObjectTest.phprenamed+5 −7
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentContentObjectTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+4912 −107
- typo3/sysext/frontend/Tests/Functional/ContentObject/ImageContentObjectTest.phpnew+323 −0
- typo3/sysext/frontend/Tests/Functional/DataProcessing/SiteLanguageProcessorTest.phprenamed+5 −5
- typo3/sysext/frontend/Tests/Functional/DataProcessing/SiteProcessorTest.php+54 −28
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+3 −6
- typo3/sysext/frontend/Tests/Functional/Processor/GalleryProcessorTest.phprenamed+11 −42
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/AfterContentObjectRendererInitializedEventTest.php+1 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/AfterGetDataResolvedEventTest.php+2 −6
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/BeforeStdWrapContentStoredInCacheEventTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/EnhanceStdWrapEventTest.php+4 −9
- typo3/sysext/frontend/Tests/Unit/ContentObject/Event/ModifyImageSourceCollectionEventTest.php+2 −6
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentDataProcessorTest.php+5 −10
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.phpdeleted+0 −7526
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.phpdeleted+0 −535
- typo3/sysext/frontend/Tests/Unit/DataProcessing/SiteProcessorTest.phpdeleted+0 −58
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php+24 −64
- typo3/sysext/frontend/Tests/Unit/Typolink/ExternalUrlLinkBuilderTest.php+10 −13
- typo3/sysext/frontend/Tests/Unit/Typolink/PageLinkBuilderTest.php+2 −2
Review log 4484
Show 3159 earlier messages
-
Christian Kuhn uploaded patch set 1 11/14/25, 22:30
-
Christian Kuhn uploaded patch set 2 11/14/25, 22:43
-
core-ci voted on patch set 1 V -1 11/14/25, 22:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89735
-
Christian Kuhn uploaded patch set 3 11/14/25, 22:46
-
core-ci voted on patch set 2 V -1 11/14/25, 22:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89736
-
core-ci voted on patch set 3 V -1 11/14/25, 22:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89737
-
Christian Kuhn uploaded patch set 4
V -111/14/25, 23:02 -
core-ci voted on patch set 4 V +1 11/14/25, 23:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89738
-
Christian Kuhn uploaded patch set 5
V +111/14/25, 23:20 -
core-ci voted on patch set 5 V -1 11/14/25, 23:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89739
-
Christian Kuhn uploaded patch set 6
V -111/14/25, 23:44 -
core-ci voted on patch set 6 V -1 11/14/25, 23:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89740
-
Christian Kuhn uploaded patch set 7
V -111/15/25, 00:07 -
core-ci voted on patch set 7 V -1 11/15/25, 00:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89741
-
Christian Kuhn uploaded patch set 8
V -111/15/25, 00:49 -
core-ci voted on patch set 8 V -1 11/15/25, 00:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89742
-
Christian Kuhn uploaded patch set 9
V -111/15/25, 00:58 -
core-ci voted on patch set 9 V -1 11/15/25, 01:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89743
-
Christian Kuhn uploaded patch set 10
V -111/15/25, 01:55 -
Christian Kuhn uploaded patch set 11 11/15/25, 02:02
-
core-ci voted on patch set 10 V -1 11/15/25, 02:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89746
-
Christian Kuhn uploaded patch set 12 11/15/25, 02:05
-
core-ci voted on patch set 11 V -1 11/15/25, 02:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89747
-
Christian Kuhn uploaded patch set 13 11/15/25, 02:15
-
core-ci voted on patch set 12 V -1 11/15/25, 02:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89749
-
core-ci voted on patch set 13 V -1 11/15/25, 02:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89750
-
Christian Kuhn uploaded patch set 14
V -111/15/25, 03:18 -
core-ci voted on patch set 14 V -1 11/15/25, 03:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89752
-
Christian Kuhn uploaded patch set 15
V -111/15/25, 03:50 -
core-ci voted on patch set 15 V -1 11/15/25, 03:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89753
-
Christian Kuhn uploaded patch set 16
V -111/15/25, 13:17 -
core-ci voted on patch set 16 V -1 11/15/25, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89792
-
Christian Kuhn uploaded patch set 17
V -111/15/25, 13:34 -
core-ci voted on patch set 17 V -1 11/15/25, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89794
-
Christian Kuhn uploaded patch set 18
V -111/15/25, 13:50 -
core-ci voted on patch set 18 V -1 11/15/25, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89798
-
Christian Kuhn uploaded patch set 19
V -111/15/25, 14:24 -
core-ci voted on patch set 19 V -1 11/15/25, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89800
-
Christian Kuhn uploaded patch set 20
V -111/15/25, 16:06 -
core-ci voted on patch set 20 V -1 11/15/25, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89806
-
Christian Kuhn uploaded patch set 21
V -111/16/25, 00:43 -
core-ci voted on patch set 21 V -1 11/16/25, 00:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89821
-
Christian Kuhn uploaded patch set 22
V -111/16/25, 02:12 -
core-ci voted on patch set 22 V -1 11/16/25, 02:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89825
-
Christian Kuhn uploaded patch set 23
V -111/16/25, 03:02 -
core-ci voted on patch set 23 V -1 11/16/25, 03:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89826
-
Christian Kuhn uploaded patch set 24
V -111/16/25, 03:16 -
core-ci voted on patch set 24 V +1 11/16/25, 03:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89828
-
Christian Kuhn uploaded patch set 25
V +111/16/25, 03:25 -
core-ci voted on patch set 25 V +1 11/16/25, 03:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89829
-
Christian Kuhn uploaded patch set 26
V +111/16/25, 03:54 -
core-ci voted on patch set 26 V +1 11/16/25, 04:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89830
-
Christian Kuhn uploaded patch set 27
V +111/16/25, 15:11 -
core-ci voted on patch set 27 V +1 11/16/25, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89861
-
Christian Kuhn uploaded patch set 28
V +111/16/25, 15:28 -
Christian Kuhn uploaded patch set 29 11/16/25, 15:36
-
core-ci voted on patch set 28 V -1 11/16/25, 15:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89862
-
Christian Kuhn uploaded patch set 30 11/16/25, 15:40
-
Christian Kuhn uploaded patch set 31 11/16/25, 15:43
-
core-ci voted on patch set 29 V +1 11/16/25, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89863
-
Christian Kuhn uploaded patch set 32 11/16/25, 15:48
-
core-ci voted on patch set 30 V +1 11/16/25, 15:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89864
-
core-ci voted on patch set 31 V +1 11/16/25, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89865
-
core-ci voted on patch set 32 V -1 11/16/25, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89866
-
Christian Kuhn uploaded patch set 33
V -111/16/25, 16:07 -
core-ci voted on patch set 33 V -1 11/16/25, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89867
-
Christian Kuhn uploaded patch set 34
V -111/16/25, 17:13 -
core-ci voted on patch set 34 V +1 11/16/25, 17:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89874
-
Christian Kuhn uploaded patch set 35
V +111/16/25, 17:28 -
Christian Kuhn uploaded patch set 36 11/16/25, 17:37
-
core-ci voted on patch set 35 V +1 11/16/25, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89876
-
core-ci voted on patch set 36 V -1 11/16/25, 17:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89877
-
Christian Kuhn uploaded patch set 37
V -111/16/25, 18:01 -
core-ci voted on patch set 37 V +1 11/16/25, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89878
-
Christian Kuhn uploaded patch set 38
V +111/16/25, 18:15 -
Christian Kuhn uploaded patch set 39 11/16/25, 18:16
-
core-ci voted on patch set 38 V +1 11/16/25, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89879
-
core-ci voted on patch set 39 V +1 11/16/25, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89880
-
Christian Kuhn uploaded patch set 40
V +111/17/25, 10:51 -
core-ci voted on patch set 40 V +1 11/17/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89933
-
Stefan Bürk voted on patch set 40 CR +1 V +1 11/17/25, 12:22
-
Anja Leichsenring voted on patch set 40 CR +1 V +1 11/17/25, 13:30
-
Christian Kuhn voted on patch set 40 CR +2 V +2 11/17/25, 13:31
-
Christian Kuhn merged patch set 41 11/17/25, 13:31