Review main Merged

91675[TASK] Detect and remove duplicate XLIFF label identifiers

Lina Wolf CR +2 V +2 Easy +33 −8 updated 11/19/25, 16:14

Commit message

The integrity check `checkIntegrityXliff` is now enhanced to detect
duplicate label identifiers in both XLIFF 1.2 and XLIFF 2.0 files.
Previously, duplicate <trans-unit> / <unit> ids were not reported,
which allowed conflicting or ambiguous source texts to slip into
language files and caused inconsistent UI output.

The improved checker now:
* validates uniqueness of label IDs within each XLIFF file
* applies the logic uniformly to XLIFF 1.2 (<trans-unit>) and XLIFF 2.0 (<unit>)
* returns explicit errors for duplicate identifiers

All duplicate label occurrences found in the codebase have been
cleaned up by either merging identical content or introducing new,
more specific identifiers where different messages existed under
the same key.

This increases translation consistency and prevents future regressions
by ensuring that every label ID has exactly one semantic meaning.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 69

  1. Lina Wolf uploaded patch set 1 11/15/25, 11:55

  2. core-ci voted on patch set 1 V -1 11/15/25, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89786

  3. Lina Wolf uploaded patch set 2 V -1 11/15/25, 13:11

  4. Garvin Hicking updated the commit message in patch set 3 11/15/25, 13:13

  5. Garvin Hicking commented on patch set 3 CR +1 V +1 11/15/25, 13:13

    Freat engancement!
  6. core-ci voted on patch set 2 V +1 11/15/25, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89790

  7. core-ci voted on patch set 3 V +1 11/15/25, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89791

  8. Benni Mack voted on patch set 3 CR +2 V +2 11/19/25, 16:13

  9. Benni Mack merged patch set 4 11/19/25, 16:14