Review main Merged

91685[BUGFIX] Correct dom order after flatpicker initialization

Benjamin Kott CR +2 V +2 Easy +8 −1 updated 11/17/25, 07:27

Commit message

Flatpickr’s altInput feature inserts a hidden input
before the visible input, altering the expected DOM
structure within input groups. This causes the visible
input to no longer be the :first-child, which leads
CSS rules that unset the border-radius for non-first
inputs to affect it incorrectly.

The hidden input is now moved after the clearable
wrapper to restore the correct element order,
ensuring the visible input remains the first child
and its border-radius is not unset.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. Benjamin Kott uploaded patch set 1 11/15/25, 18:17

  2. Benjamin Kott rebased onto patch set 2 11/15/25, 18:18

  3. Benjamin Kott updated the commit message in patch set 3 11/15/25, 18:24

  4. core-ci voted on patch set 1 V +1 11/15/25, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89815

  5. core-ci voted on patch set 2 V +1 11/15/25, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89816

  6. core-ci voted on patch set 3 V +1 11/15/25, 18:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89818

  7. Benjamin Kott rebased onto patch set 4 V +1 11/16/25, 08:20

  8. core-ci voted on patch set 4 V +1 11/16/25, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89846

  9. Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/16/25, 23:47

  10. Andreas Kienast voted on patch set 4 CR +1 V +1 11/17/25, 06:40

  11. Oli Bartsch voted on patch set 4 CR +2 V +2 11/17/25, 07:27

  12. Oli Bartsch merged patch set 5 11/17/25, 07:27