Review main Merged

91687[TASK] Separate Storage Adapters for Form Extension

Josua Vogel CR +2 V +2 Nightmare +2193 −1655 updated 12/30/25, 09:41

Commit message

The storage adapter pattern has been introduced to provide a clean separation of concerns for form persistence in TYPO3.
Previously, form storage logic was tightly coupled to specific storage implementations, making it difficult to extend or modify the persistence layer.
This architectural improvement lays the foundation for supporting multiple storage backends while maintaining a consistent API for form persistence operations.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 32

Show 12 more files

Review log 3663

Show 2138 earlier messages
  1. Josua Vogel uploaded patch set 1 11/15/25, 22:38

  2. core-ci voted on patch set 1 V -1 11/15/25, 22:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89820

  3. Josua Vogel uploaded patch set 2 V -1 11/26/25, 16:45

  4. core-ci voted on patch set 2 V -1 11/26/25, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91039

  5. Josua Vogel uploaded patch set 3 V -1 11/27/25, 15:15

  6. core-ci voted on patch set 3 V -1 11/27/25, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91113

  7. Josua Vogel uploaded patch set 4 V -1 11/27/25, 15:43

  8. Josua Vogel uploaded patch set 5 11/27/25, 15:44

  9. core-ci voted on patch set 4 V -1 11/27/25, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91116

  10. core-ci voted on patch set 5 V -1 11/27/25, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91117

  11. Josua Vogel uploaded patch set 6 V -1 11/27/25, 19:21

  12. Josua Vogel uploaded patch set 7 11/27/25, 19:33

  13. core-ci voted on patch set 6 V -1 11/27/25, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91130

  14. Josua Vogel uploaded patch set 8 11/27/25, 19:42

  15. Josua Vogel uploaded patch set 9 11/27/25, 19:45

  16. core-ci voted on patch set 7 V -1 11/27/25, 19:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91131

  17. core-ci voted on patch set 8 V -1 11/27/25, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91133

  18. core-ci voted on patch set 9 V -1 11/27/25, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91134

  19. Josua Vogel uploaded patch set 10 V -1 12/03/25, 11:31

  20. Josua Vogel uploaded patch set 11 12/03/25, 11:33

  21. core-ci voted on patch set 10 V -1 12/03/25, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91518

  22. core-ci voted on patch set 11 V -1 12/03/25, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91521

  23. Josua Vogel uploaded patch set 12 V -1 12/03/25, 12:26

  24. Josua Vogel rebased onto patch set 13 12/03/25, 12:27

  25. core-ci voted on patch set 12 V -1 12/03/25, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91530

  26. core-ci voted on patch set 13 V -1 12/03/25, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91533

  27. Josua Vogel uploaded patch set 14 V -1 12/03/25, 14:53

  28. core-ci voted on patch set 14 V -1 12/03/25, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91539

  29. Josua Vogel uploaded patch set 15 V -1 12/03/25, 15:51

  30. Josua Vogel uploaded patch set 16 12/03/25, 15:52

  31. core-ci voted on patch set 16 V -1 12/03/25, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91544

  32. core-ci voted on patch set 15 V -1 12/03/25, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91543

  33. Soren Malling commented on patch set 16 12/04/25, 09:59

    Could a database storage be implemented in this adapter strategy? Maybe by third party. Perhaps implement a interface and have a "identifier" similar to backend layout data providers as an alternative to the "static enum"?
  34. Josua Vogel commented on patch set 16 12/04/25, 10:32

    Reply

    Hi Soren, yes. This is a preparation step to implement a database storage for form definitions inside the the core
  35. Josua Vogel commented on patch set 16 12/04/25, 10:55

    Reply

    by now this shouldn´t be a public API, no third party extension should use it. I think, as soon as we implemented the database storage, there´s no need for another adapter
  36. Josua Vogel updated the commit message in patch set 17 V -1 12/04/25, 10:56

  37. core-ci voted on patch set 17 V -1 12/04/25, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91583

  38. Josua Vogel uploaded patch set 18 V -1 12/04/25, 19:26

  1. core-ci voted on patch set 18 V -1 12/04/25, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91600

  2. Josua Vogel uploaded patch set 19 V -1 12/04/25, 19:55

  3. core-ci voted on patch set 19 V -1 12/04/25, 20:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91602

  4. Josua Vogel uploaded patch set 20 V -1 12/04/25, 20:04

  5. Josua Vogel uploaded patch set 21 12/04/25, 20:10

  6. core-ci voted on patch set 20 V -1 12/04/25, 20:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91605

  7. core-ci voted on patch set 21 V -1 12/04/25, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91606

  8. Josua Vogel uploaded patch set 22 V -1 12/04/25, 20:21

  9. core-ci voted on patch set 22 V +1 12/04/25, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91608

  10. Benni Mack commented on patch set 22 12/05/25, 15:29

    FormFrontendController.php:64

    just by reading... do we need this $formSettings anymore at all?
  11. Josua Vogel uploaded patch set 23 V +1 12/08/25, 08:25

  12. core-ci voted on patch set 23 V +1 12/08/25, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91809

  13. Josua Vogel commented on patch set 23 12/08/25, 08:36

    FormFrontendController.php:64 Reply

    Yes,well spotted! My IDE hadn't marked it as unused at all.
  14. Benni Mack uploaded patch set 24 V +1 12/27/25, 13:18

  15. core-ci voted on patch set 24 V -1 12/27/25, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92732

  16. Benni Mack uploaded patch set 25 V -1 12/28/25, 09:58

  17. core-ci voted on patch set 25 V -1 12/28/25, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92749

  18. Benni Mack uploaded patch set 26 V -1 12/28/25, 10:26

  19. core-ci voted on patch set 26 V -1 12/28/25, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92750

  20. Benni Mack uploaded patch set 27 V -1 12/28/25, 10:40

  21. core-ci voted on patch set 27 V +1 12/28/25, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92751

  22. Benni Mack voted on patch set 27 CR +1 V +1 12/28/25, 15:24

  23. Sven Liebert voted on patch set 27 CR +1 V +1 12/29/25, 22:32

  24. Benni Mack voted on patch set 27 CR +2 V +2 12/30/25, 09:41

  25. Benni Mack merged patch set 28 12/30/25, 09:41