91687[TASK] Separate Storage Adapters for Form Extension
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Sven Liebert +1
-
Verified V +2 Done
- Benni Mack +2
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 32
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −1
- typo3/sysext/form/Classes/Controller/FormFrontendController.php2+1 −4
- typo3/sysext/form/Classes/Controller/FormManagerController.php+25 −18
- typo3/sysext/form/Classes/Domain/Configuration/PersistenceConfigurationService.phpnew+193 −0
- typo3/sysext/form/Classes/Domain/DTO/FormData.phpnew+63 −0
- typo3/sysext/form/Classes/Domain/DTO/FormMetadata.phpnew+162 −0
- typo3/sysext/form/Classes/Domain/DTO/SearchCriteria.phpnew+146 −0
- typo3/sysext/form/Classes/Domain/ValueObject/FormIdentifier.phpnew+54 −0
- typo3/sysext/form/Classes/Enum/SortDirection.phpdeleted+0 −27
- typo3/sysext/form/Classes/EventListener/DataStructureIdentifierListener.php+9 −9
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+1 −1
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManager.php+183 −574
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManagerInterface.php+3 −3
- typo3/sysext/form/Classes/Storage/AbstractFileStorageAdapter.phpnew+209 −0
- typo3/sysext/form/Classes/Storage/ExtensionStorageAdapter.phpnew+299 −0
- typo3/sysext/form/Classes/Storage/FileMountStorageAdapter.phpnew+399 −0
- typo3/sysext/form/Classes/Storage/StorageAdapterFactory.phpnew+151 −0
- typo3/sysext/form/Classes/Storage/StorageAdapterInterface.phpnew+105 −0
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+1 −4
- typo3/sysext/form/Configuration/Services.yaml+9 −0
Show 12 more files
- typo3/sysext/form/Tests/Functional/Controller/FormFrontendControllerTest.php+0 −4
- typo3/sysext/form/Tests/Functional/Controller/FormManagerControllerTest.php+16 −20
- typo3/sysext/form/Tests/Functional/EventListener/DataStructureIdentifierListenerTest.php+20 −14
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/DatabaseImports/be_users.csvnew+4 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/DatabaseImports/sys_file_storage.csvnew+4 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/Extensions/test_form_persistence/Resources/Private/Forms/TestForm.form.yamlnew+14 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/Extensions/test_form_persistence/composer.jsonnew+14 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/Extensions/test_form_persistence/ext_emconf.phpnew+21 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/Folders/fileadmin/form_definitions/TestFilemountForm.form.yamlnew+14 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/formSetup.typoscriptnew+7 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/Fixtures/FormSetup.yamlnew+3 −0
- typo3/sysext/form/Tests/Functional/Mvc/Persistence/FormPersistenceManagerTest.php+62 −976
Review log 3663
Show 2138 earlier messages
-
Josua Vogel uploaded patch set 1 11/15/25, 22:38
-
core-ci voted on patch set 1 V -1 11/15/25, 22:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89820
-
Josua Vogel uploaded patch set 2
V -111/26/25, 16:45 -
core-ci voted on patch set 2 V -1 11/26/25, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91039
-
Josua Vogel uploaded patch set 3
V -111/27/25, 15:15 -
core-ci voted on patch set 3 V -1 11/27/25, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91113
-
Josua Vogel uploaded patch set 4
V -111/27/25, 15:43 -
Josua Vogel uploaded patch set 5 11/27/25, 15:44
-
core-ci voted on patch set 4 V -1 11/27/25, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91116
-
core-ci voted on patch set 5 V -1 11/27/25, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91117
-
Josua Vogel uploaded patch set 6
V -111/27/25, 19:21 -
Josua Vogel uploaded patch set 7 11/27/25, 19:33
-
core-ci voted on patch set 6 V -1 11/27/25, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91130
-
Josua Vogel uploaded patch set 8 11/27/25, 19:42
-
Josua Vogel uploaded patch set 9 11/27/25, 19:45
-
core-ci voted on patch set 7 V -1 11/27/25, 19:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91131
-
core-ci voted on patch set 8 V -1 11/27/25, 19:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91133
-
core-ci voted on patch set 9 V -1 11/27/25, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91134
-
Josua Vogel uploaded patch set 10
V -112/03/25, 11:31 -
Josua Vogel uploaded patch set 11 12/03/25, 11:33
-
core-ci voted on patch set 10 V -1 12/03/25, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91518
-
core-ci voted on patch set 11 V -1 12/03/25, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91521
-
Josua Vogel uploaded patch set 12
V -112/03/25, 12:26 -
Josua Vogel rebased onto patch set 13 12/03/25, 12:27
-
core-ci voted on patch set 12 V -1 12/03/25, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91530
-
core-ci voted on patch set 13 V -1 12/03/25, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91533
-
Josua Vogel uploaded patch set 14
V -112/03/25, 14:53 -
core-ci voted on patch set 14 V -1 12/03/25, 15:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91539
-
Josua Vogel uploaded patch set 15
V -112/03/25, 15:51 -
Josua Vogel uploaded patch set 16 12/03/25, 15:52
-
core-ci voted on patch set 16 V -1 12/03/25, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91544
-
core-ci voted on patch set 15 V -1 12/03/25, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91543
-
Soren Malling commented on patch set 16 12/04/25, 09:59
Could a database storage be implemented in this adapter strategy? Maybe by third party. Perhaps implement a interface and have a "identifier" similar to backend layout data providers as an alternative to the "static enum"? -
Josua Vogel commented on patch set 16 12/04/25, 10:32
Reply
Hi Soren, yes. This is a preparation step to implement a database storage for form definitions inside the the core -
Josua Vogel commented on patch set 16 12/04/25, 10:55
Reply
by now this shouldn´t be a public API, no third party extension should use it. I think, as soon as we implemented the database storage, there´s no need for another adapter -
Josua Vogel updated the commit message in patch set 17
V -112/04/25, 10:56 -
core-ci voted on patch set 17 V -1 12/04/25, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91583
-
Josua Vogel uploaded patch set 18
V -112/04/25, 19:26
-
core-ci voted on patch set 18 V -1 12/04/25, 19:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91600
-
Josua Vogel uploaded patch set 19
V -112/04/25, 19:55 -
core-ci voted on patch set 19 V -1 12/04/25, 20:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91602
-
Josua Vogel uploaded patch set 20
V -112/04/25, 20:04 -
Josua Vogel uploaded patch set 21 12/04/25, 20:10
-
core-ci voted on patch set 20 V -1 12/04/25, 20:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91605
-
core-ci voted on patch set 21 V -1 12/04/25, 20:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91606
-
Josua Vogel uploaded patch set 22
V -112/04/25, 20:21 -
core-ci voted on patch set 22 V +1 12/04/25, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91608
-
Benni Mack commented on patch set 22 12/05/25, 15:29
FormFrontendController.php:64just by reading... do we need this $formSettings anymore at all? -
Josua Vogel uploaded patch set 23
V +112/08/25, 08:25 -
core-ci voted on patch set 23 V +1 12/08/25, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/91809
-
Josua Vogel commented on patch set 23 12/08/25, 08:36
FormFrontendController.php:64ReplyYes,well spotted! My IDE hadn't marked it as unused at all. -
Benni Mack uploaded patch set 24
V +112/27/25, 13:18 -
core-ci voted on patch set 24 V -1 12/27/25, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92732
-
Benni Mack uploaded patch set 25
V -112/28/25, 09:58 -
core-ci voted on patch set 25 V -1 12/28/25, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92749
-
Benni Mack uploaded patch set 26
V -112/28/25, 10:26 -
core-ci voted on patch set 26 V -1 12/28/25, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92750
-
Benni Mack uploaded patch set 27
V -112/28/25, 10:40 -
core-ci voted on patch set 27 V +1 12/28/25, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92751
-
Benni Mack voted on patch set 27 CR +1 V +1 12/28/25, 15:24
-
Sven Liebert voted on patch set 27 CR +1 V +1 12/29/25, 22:32
-
Benni Mack voted on patch set 27 CR +2 V +2 12/30/25, 09:41
-
Benni Mack merged patch set 28 12/30/25, 09:41