Review main Merged

91688[TASK] Migrate module identifiers in user and group permissions

Lina Wolf CR +2 V +2 Normal +191 −0 updated 11/20/25, 21:28

Commit message

As part of renaming backend modules, their identifiers have been updated
to reflect the new module names.

Module identifiers are stored in the be_users and be_groups tables to
control module-level permissions. While defining identifier aliases keeps
existing permissions functional, these aliases are not considered in the
record editor when editing permissions.

An upgrade wizard is introduced to migrate stored module identifiers to
their new names.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1521

  1. Lina Wolf uploaded patch set 1 11/16/25, 04:53

  2. Lina Wolf updated the commit message in patch set 2 11/16/25, 04:54

  3. core-ci voted on patch set 1 V +1 11/16/25, 05:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89837

  4. core-ci voted on patch set 2 V +1 11/16/25, 05:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89838

  5. Oli Bartsch commented on patch set 2 11/18/25, 09:16

    UserPermissionsForRenamedModulesMigration.php:28

    userPermissionsForRenamedModulesMigration

    UserPermissionsForRenamedModulesMigration.php:35

    empty line before

    UserPermissionsForRenamedModulesMigration.php:84

    This might be distorted duie to the `trim`

    UserPermissionsForRenamedModulesMigration.php:85

    I suggest to set migrated based on the actual `->update()` result.

    UserPermissionsForRenamedModulesMigration.php:102

    I think this method is superfluous.

    UserPermissionsForRenamedModulesBase.csv:6

    I suggest to add more examples, even invalid db state like duplicated module identifiers etc. Upgrade Wizards should never ever fail and must handle all kind of invalid db state, we never know what installations out there are doing manually. ;)
  6. Lina Wolf uploaded patch set 3 V +1 11/18/25, 14:18

  7. Lina Wolf commented on patch set 3 11/18/25, 14:19

    UserPermissionsForRenamedModulesMigration.php:28 Reply

    Done

    UserPermissionsForRenamedModulesMigration.php:35 Reply

    Done

    UserPermissionsForRenamedModulesMigration.php:84 Reply

    Done

    UserPermissionsForRenamedModulesMigration.php:85 Reply

    Done
  8. Lina Wolf uploaded patch set 4 11/18/25, 14:20

  9. Lina Wolf commented on patch set 4 11/18/25, 14:22

    UserPermissionsForRenamedModulesMigration.php:102 Reply

    Done

    UserPermissionsForRenamedModulesBase.csv:6 Reply

    Done
  10. core-ci voted on patch set 3 V +1 11/18/25, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90034

  11. core-ci voted on patch set 4 V +1 11/18/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90035

  12. Benni Mack commented on patch set 4 11/18/25, 16:08

    UserPermissionsForRenamedModulesMigration.php:39

    we can actually use "web" => "content" right away?

    UserPermissionsForRenamedModulesMigration.php:89

    $migrated gets overridden, so only the last value counts. Should we have this at all? Maybe I don't fully understand...
  13. Lina Wolf commented on patch set 4 11/19/25, 12:34

    UserPermissionsForRenamedModulesMigration.php:39 Reply

    It is not possible to grant rights for Top Level Modules. They appear as soon as one of their Second level modules is visible.
  14. Lina Wolf uploaded patch set 5 V +1 11/19/25, 12:36

  15. Lina Wolf commented on patch set 5 11/19/25, 12:38

    UserPermissionsForRenamedModulesMigration.php:89 Reply

    Fixed it now. It is the return value of the "executeUpdate()" function.
  16. core-ci voted on patch set 5 V -1 11/19/25, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90132

  17. Lina Wolf uploaded patch set 6 V -1 11/19/25, 13:04

  18. core-ci voted on patch set 6 V +1 11/19/25, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90137

  19. Benni Mack voted on patch set 6 CR +1 V +1 11/20/25, 18:29

  20. Oli Bartsch commented on patch set 6 CR +2 V +2 11/20/25, 21:27

    Awesome, thanks!
  21. Oli Bartsch merged patch set 7 11/20/25, 21:28