91688[TASK] Migrate module identifiers in user and group permissions
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/install/Classes/Updates/UserPermissionsForRenamedModulesMigration.php14new+106 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/UserPermissionsForRenamedModulesBase.csv2new+16 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/UserPermissionsForRenamedModulesMigrated.csvnew+16 −0
- typo3/sysext/install/Tests/Functional/Updates/UserPermissionsForRenamedModulesMigrationTest.phpnew+53 −0
Review log 1521
-
Lina Wolf uploaded patch set 1 11/16/25, 04:53
-
Lina Wolf updated the commit message in patch set 2 11/16/25, 04:54
-
core-ci voted on patch set 1 V +1 11/16/25, 05:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89837
-
core-ci voted on patch set 2 V +1 11/16/25, 05:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89838
-
Oli Bartsch commented on patch set 2 11/18/25, 09:16
UserPermissionsForRenamedModulesMigration.php:35empty line beforeUserPermissionsForRenamedModulesMigration.php:84This might be distorted duie to the `trim`UserPermissionsForRenamedModulesMigration.php:85I suggest to set migrated based on the actual `->update()` result.UserPermissionsForRenamedModulesMigration.php:102I think this method is superfluous.UserPermissionsForRenamedModulesBase.csv:6I suggest to add more examples, even invalid db state like duplicated module identifiers etc. Upgrade Wizards should never ever fail and must handle all kind of invalid db state, we never know what installations out there are doing manually. ;) -
Lina Wolf uploaded patch set 3
V +111/18/25, 14:18 -
Lina Wolf commented on patch set 3 11/18/25, 14:19
UserPermissionsForRenamedModulesMigration.php:28ReplyDoneUserPermissionsForRenamedModulesMigration.php:35ReplyDoneUserPermissionsForRenamedModulesMigration.php:84ReplyDoneUserPermissionsForRenamedModulesMigration.php:85ReplyDone -
Lina Wolf uploaded patch set 4 11/18/25, 14:20
-
Lina Wolf commented on patch set 4 11/18/25, 14:22
UserPermissionsForRenamedModulesMigration.php:102ReplyDoneUserPermissionsForRenamedModulesBase.csv:6ReplyDone -
core-ci voted on patch set 3 V +1 11/18/25, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90034
-
core-ci voted on patch set 4 V +1 11/18/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90035
-
Benni Mack commented on patch set 4 11/18/25, 16:08
UserPermissionsForRenamedModulesMigration.php:39we can actually use "web" => "content" right away?UserPermissionsForRenamedModulesMigration.php:89$migrated gets overridden, so only the last value counts. Should we have this at all? Maybe I don't fully understand... -
Lina Wolf commented on patch set 4 11/19/25, 12:34
UserPermissionsForRenamedModulesMigration.php:39ReplyIt is not possible to grant rights for Top Level Modules. They appear as soon as one of their Second level modules is visible. -
Lina Wolf uploaded patch set 5
V +111/19/25, 12:36 -
Lina Wolf commented on patch set 5 11/19/25, 12:38
UserPermissionsForRenamedModulesMigration.php:89ReplyFixed it now. It is the return value of the "executeUpdate()" function. -
core-ci voted on patch set 5 V -1 11/19/25, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90132
-
Lina Wolf uploaded patch set 6
V -111/19/25, 13:04 -
core-ci voted on patch set 6 V +1 11/19/25, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90137
-
Benni Mack voted on patch set 6 CR +1 V +1 11/20/25, 18:29
-
Oli Bartsch commented on patch set 6 CR +2 V +2 11/20/25, 21:27
Awesome, thanks! -
Oli Bartsch merged patch set 7 11/20/25, 21:28
UserPermissionsForRenamedModulesMigration.php:28