Review main Merged

91689[BUGFIX] Prevent double initialization of clearable in datepicker

Benjamin Kott CR +2 V +2 Easy +3 −3 updated 11/17/25, 08:50

Commit message

When using flatpickr with altInput, the clearable functionality was
being initialized twice: once on the original input field and once
on the flatpickr altInput. This resulted in duplicate clear buttons
being rendered.

This change removes the global markup trigger from places where they
have not been removed in the past (#107738).

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Benjamin Kott uploaded patch set 1 11/16/25, 08:20

  2. core-ci voted on patch set 1 V +1 11/16/25, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89847

  3. Benjamin Franzke commented on patch set 1 CR -1 11/17/25, 02:37

    date-time-picker.ts:66

    I fixed this recently for FormEngine by removing the `t3js-clearable` class from datetime elements via > [BUGFIX] Maintain focus after clearing a clearable input field > https://review.typo3.org/c/Packages/TYPO3.CMS/+/91112/4/typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php#b145 …but I missed to apply this fix (removing that global trigger class) to the custom usages in typo3/sysext/belog/Resources/Private/Partials/Content/Filter.html and typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php So these are the places where you faced it, right? In formengine I could no longer reproduce a double initialization. I'm sorry for missing these, but I don't think it is a good idea to keep this practice of initializing twice and applying a workaround by unregistering a previous (unneeded!) initialization, instead we should leave it to the date time picker to handle/trigger the clearable implementation completely on its own, like the combobox does. Are you ok with that or did you also/still face problems in FormEngine?
  4. Benjamin Franzke uploaded patch set 2 CR -1 V +1 11/17/25, 07:53

  5. Benjamin Franzke voted on patch set 2 CR +1 V +1 11/17/25, 07:54

  6. core-ci voted on patch set 2 V +1 11/17/25, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89905

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 11/17/25, 08:16

  8. Benjamin Kott voted on patch set 2 CR +2 V +2 11/17/25, 08:33

  9. Benjamin Kott commented on patch set 2 11/17/25, 08:33

    date-time-picker.ts:66 Reply

    Acknowledged
  10. Benjamin Kott merged patch set 3 11/17/25, 08:50