Review main Merged

91696[TASK] Avoid unintentional null value for form ViewHelpers

Simon Praetorius CR +2 V +2 Easy +8 −8 updated 11/16/25, 17:11

Commit message

With Fluid 5, `null` being passed to `TagBuilder` will behave
differently: Before, this lead to `value=""`, now it will lead to
the attribute being omitted from the resulting HTML tag.

For Form ViewHelpers this can be problematic because HTML form elements
sometimes behave differently: The `<option>` tag, for example, falls
back to the option's label if the `value` attribute is omitted, which
is not what we usually want (and it differs from the current
implementation).

In preparation for the raise of Fluid to 5.0.0, the affected form
ViewHelper are adjusted to always cast the value to string, which
makes sure that their behavior stays the same after the raise.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 8

Review log 56

  1. Simon Praetorius uploaded patch set 1 11/16/25, 16:48

  2. core-ci voted on patch set 1 V +1 11/16/25, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89871

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 11/16/25, 16:59

  4. Christian Kuhn voted on patch set 1 CR +1 V +1 11/16/25, 17:11

  5. Simon Praetorius voted on patch set 1 CR +2 V +2 11/16/25, 17:11

  6. Simon Praetorius merged patch set 2 11/16/25, 17:11