Review main Abandoned

91699[BUGFIX] Ensure uri.page and link.page work the same

Markus Klein CR 0 V 0 Hard +87 −219 updated 11/18/25, 10:14

Commit message

Remove all code duplication from the viewhelpers
by centralizing the code within uri.page.

Furthermore, ensure that all arguments are
processed identical with/-out extbase context.

All arguments have been checked one-by-one
to ensure default values and data types
are processed correctly.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 2

Review log 1117

  1. Markus Klein uploaded patch set 1 11/17/25, 00:24

  2. Markus Klein uploaded patch set 2 11/17/25, 00:28

  3. Markus Klein uploaded patch set 3 11/17/25, 00:36

  4. core-ci voted on patch set 1 V -1 11/17/25, 00:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89885

  5. core-ci voted on patch set 2 V -1 11/17/25, 00:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89886

  6. core-ci voted on patch set 3 V -1 11/17/25, 00:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89887

  7. Markus Klein uploaded patch set 4 V -1 11/17/25, 01:18

  8. core-ci voted on patch set 4 V +1 11/17/25, 01:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89890

  9. Oli Bartsch commented on patch set 4 CR -1 11/17/25, 07:36

    I'm strongly against using one VH as a service for another. While I also like to avoid duplicate code, we explicitly decided not to extend VHs and to treat them as independent services. So we should either move the shared logic into a dedicated service used by both VHs, or simply live with the duplicated code, which would be totally fine for me here. In any case, we need test coverage.
  10. Markus Klein commented on patch set 4 11/17/25, 08:43

    Reply

    We discussed that lengthy already here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91396/comment/ad02a315_a83927bd/ Please lets get that straight and done. We only fuck up our future if we keep this code duplicated. You see the mess this caused over time at hand.
  11. Oli Bartsch commented on patch set 4 CR 0 11/17/25, 09:59

    Reply

    I still think that we are introducing bad architecture and also lack relevant test coverage. However due to necessity of the backport I won’t block this patch if this will be cleaned up for main afterwards. Removing -1.
  12. Markus Klein commented on patch set 4 11/17/25, 10:27

    Reply

    Thanks!
  13. Markus Klein rebased onto patch set 5 V +1 11/17/25, 23:53

  14. core-ci voted on patch set 5 V +1 11/18/25, 00:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89976

  15. Markus Klein uploaded patch set 6 11/18/25, 09:02

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  16. core-ci voted on patch set 6 V +1 11/18/25, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90001

  17. Markus Klein abandoned the change 11/18/25, 10:14