Review main Merged

91702[BUGFIX] Make tree labels localizable

Georg Ringer CR +2 V +2 Easy +2 −2 updated 11/20/25, 20:59

Commit message

Use `LanguageService::sL` to have labels in the page & file tree which
can be localized.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1113

  1. Georg Ringer uploaded patch set 1 11/17/25, 07:48

  2. Georg Ringer commented on patch set 1 11/17/25, 07:49

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/17/25, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89904

  4. Benni Mack voted on patch set 1 CR +1 11/17/25, 16:03

  5. Garvin Hicking commented on patch set 1 CR -1 V +1 11/17/25, 18:35

    Please also check out `typo3/sysext/backend/Classes/Controller/FileStorage/TreeController.php` - I think the same "label" patch needs to be applied. I would actually prefer if the "Label" DTO could itself apply labelling, and not from the outside. But getting to the language service in that DTO looks like some pain, so I guess fixing it like that in the consumers is fair game. (It works for the single instance, btw - tested with both a "backend.modules.about.title" and "LLL:EXT..." syntax).
  6. Georg Ringer uploaded patch set 2 CR +1 V +1 11/18/25, 22:18

  7. core-ci voted on patch set 2 V +1 11/18/25, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90078

  8. Lina Wolf commented on patch set 2 11/19/25, 12:43

    How can I test this?
  9. Georg Ringer commented on patch set 2 11/19/25, 13:19

    @lina see forge issue
  10. Garvin Hicking voted on patch set 2 CR +1 V +1 11/19/25, 21:57

  11. Lina Wolf commented on patch set 2 CR +1 V +1 11/20/25, 11:56

    Works as expected
  12. Oli Bartsch voted on patch set 2 CR +2 V +2 11/20/25, 20:59

  13. Oli Bartsch merged patch set 3 11/20/25, 20:59