Review main Merged

91707[TASK] Dynamically generate color tokens using relative colors

Benjamin Franzke CR +2 V +2 Easy +38 −12 updated 11/18/25, 15:44

Commit message

Apply the same operation as the SASS method via
browser builtin relatrive color notation in order to
prepare for dynamic recalculations based on changes
to the respective `--token-color-*-base` token.

The colors are grouped into CSS layers in order
for browsers like google chrome to group these
root properties, which increases performance
when navigating the chrome inspector and when
changing property values.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Benjamin Franzke uploaded patch set 1 11/17/25, 08:49

  2. core-ci voted on patch set 1 V +1 11/17/25, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89919

  3. Benjamin Franzke uploaded patch set 2 V +1 11/17/25, 09:16

  4. core-ci voted on patch set 2 V +1 11/17/25, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89922

  5. Benjamin Franzke uploaded patch set 3 V +1 11/17/25, 11:38

  6. Benjamin Franzke commented on patch set 3 11/17/25, 11:42

    Try `:root { --token-color-neutral-base: hotpink; }`
  7. core-ci voted on patch set 3 V -1 11/17/25, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89935

  8. Benjamin Franzke uploaded patch set 4 V -1 11/17/25, 12:05

  9. core-ci voted on patch set 4 V +1 11/17/25, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89936

  10. Benjamin Kott voted on patch set 4 CR +1 V +1 11/18/25, 15:30

  11. Andreas Kienast voted on patch set 4 CR +1 V +1 11/18/25, 15:35

  12. Benjamin Franzke voted on patch set 4 CR +2 V +2 11/18/25, 15:44

  13. Benjamin Franzke merged patch set 5 11/18/25, 15:44