91712[BUGFIX] Ensure f:*.action VHs use current page if pageUid is empty
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Moritz Ngo +1
-
Verified V +2 Done
- Christian Kuhn +2
- Markus Klein +1
- Moritz Ngo +1
- core-ci +1 CI
Issues 2
Files 3
Review log 2126
Show 1 earlier messages
-
Moritz Ngo uploaded patch set 1 11/17/25, 14:46
-
Moritz Ngo marked it ready for review 11/17/25, 14:47
-
Oliver Klee updated the commit message in patch set 2 11/17/25, 14:52
-
core-ci voted on patch set 1 V -1 11/17/25, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89947
-
Moritz Ngo uploaded patch set 3 11/17/25, 14:57
-
core-ci voted on patch set 2 V -1 11/17/25, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89948
-
core-ci voted on patch set 3 V -1 11/17/25, 15:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89949
-
Markus Klein commented on patch set 3 11/17/25, 15:24
Thanks for your patch. I'll take a look at it. First quick look tells me that you do a bit too much. The pageType-Handling must not be changed, as this is breaking. We have a dedicated patch for this https://forge.typo3.org/issues/107347 -
Chris Müller commented on patch set 3 11/17/25, 15:24
PageViewHelper.php:185This can be shortened with: $pageUid = (int)($arguments['pageUid'] ?? 0); also the other isset checks. -
Markus Klein commented on patch set 3 CR -1 11/17/25, 15:47
PageViewHelper.php:185ReplyPlease, no further changes with this fix. This change alone breaks things again! "pageUid" has a default value of `null`, which means "preserve current page", aka `"current"` in Typolink syntax. Casting this to 0 may have side-effects. -
Chris Müller commented on patch set 3 11/17/25, 16:33
PageViewHelper.php:185ReplyAcknowledged -
Markus Klein uploaded patch set 4
CR -1V -111/18/25, 10:12 -
Markus Klein commented on patch set 4 11/18/25, 10:13
Reply
Done -
core-ci voted on patch set 4 V +1 11/18/25, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90006
-
Moritz Ngo voted on patch set 4 CR +1 V +1 11/18/25, 10:22
-
Christian Kuhn voted on patch set 4 CR +1 V +1 11/18/25, 11:20
-
Oliver Klee updated the commit message in patch set 5
CR +1V +111/18/25, 11:30 -
Christian Kuhn commented on patch set 5 CR +1 V +1 11/18/25, 11:36
would be great to see a vote from Markus. -
core-ci voted on patch set 5 V +1 11/18/25, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90013
-
Markus Klein voted on patch set 5 CR +1 V +1 11/18/25, 11:58
-
Christian Kuhn voted on patch set 5 CR +2 V +2 11/18/25, 11:59
-
Ayke Halder commented on patch set 5 CR -1 11/18/25, 12:13
ActionViewHelper.php:194This would show the real intention "not use parameter on empty string". ```suggestion $pageUid = (isset($arguments['pageUid']) && $arguments['pageUid'] !== '') ? (int)$arguments['pageUid'] : null; ``` -
Moritz Ngo commented on patch set 5 CR +1 V +1 11/18/25, 12:13
looking good and work's like charm :) -
Markus Klein commented on patch set 5 11/18/25, 12:14
ActionViewHelper.php:194ReplyPlease, this is a regression fix. Let's keep it this way. I'm rewriting this whole stuff anyway with https://review.typo3.org/c/Packages/TYPO3.CMS/+/90502 -
Ayke Halder commented on patch set 5 CR 0 11/18/25, 12:23
ActionViewHelper.php:194ReplyAcknowledged -
Christian Kuhn merged patch set 6 11/18/25, 13:12