Review main Merged

91733[BUGFIX] Correct placement of form elements inside button groups

Benjamin Kott CR +2 V +2 Normal +57 −61 updated 11/19/25, 10:07

Commit message

Moves form elements with hidden input elements to be positioned before
their associated submit buttons within btn-group containers. This ensures
that CSS :first-child and :last-child selectors correctly target the
visible button elements for proper border-radius styling.

Additionally removes invalid nested btn-group elements inside input-group
containers, as buttons within input groups should be direct children
without an intermediate btn-group wrapper.

The forms containing only hidden input elements are not visually rendered
but were interfering with the visual styling when positioned after the
buttons.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Jasmina Ließmann +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Jasmina Ließmann +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 68

  1. Benjamin Kott uploaded patch set 1 11/18/25, 12:02

  2. core-ci voted on patch set 1 V +1 11/18/25, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90016

  3. Benjamin Kott rebased onto patch set 2 V +1 11/18/25, 13:34

  4. core-ci voted on patch set 2 V +1 11/18/25, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90024

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 11/18/25, 16:45

  6. Jasmina Ließmann voted on patch set 2 CR +1 V +1 11/19/25, 09:09

  7. Benjamin Kott voted on patch set 2 CR +2 V +2 11/19/25, 09:39

  8. Benjamin Kott merged patch set 3 11/19/25, 10:07