Review main Merged

91737[TASK] Separate scaffold module menu and topbar states

Benjamin Kott CR +2 V +2 Hard +162 −138 updated 11/18/25, 18:20

Commit message

Previously, the scaffold component used globally defined CSS custom
properties with generic `--scaffold-*` prefixes and shared state
variables like `--typo3-state-default-*` that created tight coupling
between different parts of the backend UI.

This change moves state management to the component level. Scaffold
base variables are now consolidated under the `--typo3-scaffold-*`
namespace in the root CSS layer for better organization. The
`.modulemenu` and `.topbar` components now define their own
component-specific color and background variables that derive from
scaffold properties. Generic state variables for hover, focus, and
active states are replaced with component-scoped state variables
that calculate their values based on each component's base colors
using color-mix(). The toolbar item links now derive from scaffold
header properties rather than global state definitions.

This decoupling allows the topbar and module menu components to
independently adapt their appearance based on their local context
while maintaining consistency through the scaffold property
inheritance hierarchy. Components now own their state calculations
rather than relying on global state definitions.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 811

  1. Benjamin Kott uploaded patch set 1 11/18/25, 15:09

  2. Benjamin Kott uploaded patch set 2 11/18/25, 15:09

  3. Benjamin Kott commented on patch set 2 11/18/25, 15:10

    Please use for example to validate the changes. :root { --typo3-scaffold-modulemenu-bg: var(--typo3-surface-primary); --typo3-scaffold-modulemenu-color: var(--typo3-surface-primary-text); --typo3-scaffold-header-bg: var(--typo3-surface-primary); --typo3-scaffold-header-color: var(--typo3-surface-primary-text); }
  4. core-ci voted on patch set 1 V +1 11/18/25, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90043

  5. core-ci voted on patch set 2 V +1 11/18/25, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90044

  6. Andreas Kienast voted on patch set 2 CR +1 V +1 11/18/25, 15:43

  7. Andreas Kienast uploaded patch set 3 CR +1 V +1 11/18/25, 15:46

  8. Andreas Kienast voted on patch set 3 CR +1 V +1 11/18/25, 15:46

  9. core-ci voted on patch set 3 V +1 11/18/25, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90050

  10. Benni Mack commented on patch set 3 CR +2 V +2 11/18/25, 18:20

    Reply

    Done
  11. Benni Mack merged patch set 4 11/18/25, 18:20