Review main Merged

91752[BUGFIX] Support TCEFORM altLabels override for empty values

Can Adrian Karadag CR +2 V +2 Normal +125 −3 updated 12/18/25, 08:47

Commit message

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Josua Vogel +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2027

Show 12 earlier messages
  1. Can Adrian Karadag uploaded patch set 1 11/19/25, 14:14

  2. core-ci voted on patch set 1 V -1 11/19/25, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90140

  1. Garvin Hicking commented on patch set 2 V -1 11/19/25, 15:22

    Published edit on patch set 1.
  2. core-ci voted on patch set 2 V +1 11/19/25, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90159

  3. Can Adrian Karadag uploaded patch set 3 V +1 11/20/25, 09:55

  4. core-ci voted on patch set 3 V -1 11/20/25, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90249

  5. Garvin Hicking commented on patch set 3 11/20/25, 10:08

    BackendUtilityTest.php:967

    maybe add a distinct test entry for this instead of changing sn existing one
  6. Can Adrian Karadag uploaded patch set 4 V -1 11/20/25, 10:09

  7. Can Adrian Karadag commented on patch set 4 11/20/25, 10:13

    BackendUtilityTest.php:967 Reply

    I think it fits in well because the test case is exactly for that, according to the title “Tsconfig overrules TCA.” But if you see it differently, I can also move it elsewhere.
  8. core-ci voted on patch set 4 V +1 11/20/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90250

  9. Garvin Hicking commented on patch set 4 11/20/25, 10:17

    I would suggest; [BUGFIX] Support TCEFORM altLabels override for empty values That prevents a certain political soundbite ;)

    BackendUtilityTest.php:967 Reply

    I would prefer to have to more "distinct" variants, also to ensure that we have more regression failure safety nets. The one additional assertion shouldn't hurt.
  10. Can Adrian Karadag uploaded patch set 5 V +1 11/20/25, 10:30

  11. Can Adrian Karadag commented on patch set 5 11/20/25, 10:32

    BackendUtilityTest.php:967 Reply

    i decoupled the test case and added for each select renderType a own test case
  12. Can Adrian Karadag updated the commit message in patch set 6 11/20/25, 10:32

  13. Can Adrian Karadag commented on patch set 6 11/20/25, 10:33

    Reply

    haha, done 😄
  14. core-ci voted on patch set 5 V +1 11/20/25, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90257

  15. core-ci voted on patch set 6 V +1 11/20/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90258

  16. Garvin Hicking commented on patch set 6 CR +1 V +1 11/26/25, 11:00

    I think this works, but would really love feedback from @lolli@schwarzbu.ch here
  17. Josua Vogel voted on patch set 6 CR +1 V +1 12/15/25, 09:29

  18. Sven Liebert voted on patch set 6 CR +1 V +1 12/18/25, 06:18

  19. Garvin Hicking updated the commit message in patch set 7 CR +1 V +1 12/18/25, 07:41

  20. Garvin Hicking commented on patch set 7 CR +1 V +1 12/18/25, 07:42

    I think I can't justify backporting this to 12.4 in "high prio bugfiyes", so changed thee scope for it. Hope it's understandable.
  21. Sven Liebert voted on patch set 7 CR +1 V +1 12/18/25, 07:43

  22. core-ci voted on patch set 7 V +1 12/18/25, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92394

  23. Josua Vogel voted on patch set 7 CR +1 V +1 12/18/25, 07:57

  24. Garvin Hicking voted on patch set 7 CR +2 V +2 12/18/25, 08:47

  25. Garvin Hicking merged patch set 8 12/18/25, 08:47