91752[BUGFIX] Support TCEFORM altLabels override for empty values
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Josua Vogel +1
- Sven Liebert +1
-
Verified V +2 Done
- Garvin Hicking +2
- Josua Vogel +1
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+6 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+5 −2
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+10 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectTreeItemsTest.php+12 −0
- typo3/sysext/backend/Tests/Functional/Utility/BackendUtilityTest.php4+92 −0
Review log 2027
Show 12 earlier messages
-
Can Adrian Karadag uploaded patch set 1 11/19/25, 14:14
-
core-ci voted on patch set 1 V -1 11/19/25, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90140
-
Garvin Hicking commented on patch set 2
V -111/19/25, 15:22Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 11/19/25, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90159
-
Can Adrian Karadag uploaded patch set 3
V +111/20/25, 09:55 -
core-ci voted on patch set 3 V -1 11/20/25, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90249
-
Garvin Hicking commented on patch set 3 11/20/25, 10:08
BackendUtilityTest.php:967maybe add a distinct test entry for this instead of changing sn existing one -
Can Adrian Karadag uploaded patch set 4
V -111/20/25, 10:09 -
Can Adrian Karadag commented on patch set 4 11/20/25, 10:13
BackendUtilityTest.php:967ReplyI think it fits in well because the test case is exactly for that, according to the title “Tsconfig overrules TCA.” But if you see it differently, I can also move it elsewhere. -
core-ci voted on patch set 4 V +1 11/20/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90250
-
Garvin Hicking commented on patch set 4 11/20/25, 10:17
I would suggest; [BUGFIX] Support TCEFORM altLabels override for empty values That prevents a certain political soundbite ;)BackendUtilityTest.php:967ReplyI would prefer to have to more "distinct" variants, also to ensure that we have more regression failure safety nets. The one additional assertion shouldn't hurt. -
Can Adrian Karadag uploaded patch set 5
V +111/20/25, 10:30 -
Can Adrian Karadag commented on patch set 5 11/20/25, 10:32
BackendUtilityTest.php:967Replyi decoupled the test case and added for each select renderType a own test case -
Can Adrian Karadag updated the commit message in patch set 6 11/20/25, 10:32
-
Can Adrian Karadag commented on patch set 6 11/20/25, 10:33
Reply
haha, done 😄 -
core-ci voted on patch set 5 V +1 11/20/25, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90257
-
core-ci voted on patch set 6 V +1 11/20/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90258
-
Garvin Hicking commented on patch set 6 CR +1 V +1 11/26/25, 11:00
I think this works, but would really love feedback from @lolli@schwarzbu.ch here -
Josua Vogel voted on patch set 6 CR +1 V +1 12/15/25, 09:29
-
Sven Liebert voted on patch set 6 CR +1 V +1 12/18/25, 06:18
-
Garvin Hicking updated the commit message in patch set 7
CR +1V +112/18/25, 07:41 -
Garvin Hicking commented on patch set 7 CR +1 V +1 12/18/25, 07:42
I think I can't justify backporting this to 12.4 in "high prio bugfiyes", so changed thee scope for it. Hope it's understandable. -
Sven Liebert voted on patch set 7 CR +1 V +1 12/18/25, 07:43
-
core-ci voted on patch set 7 V +1 12/18/25, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/92394
-
Josua Vogel voted on patch set 7 CR +1 V +1 12/18/25, 07:57
-
Garvin Hicking voted on patch set 7 CR +2 V +2 12/18/25, 08:47
-
Garvin Hicking merged patch set 8 12/18/25, 08:47