Review main Merged

91759[BUGFIX] Handle offline storages in filemounts gracefully

Georg Ringer CR +2 V +2 Easy +2 −1 updated 11/20/25, 11:21

Commit message

If the storage selected in a `sys_filemounts` record has been set to
offline, the `sys_filemounts` records must still be editable.

This is also valid for any other folder selection, and therefore the
exception must be handled.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Georg Ringer uploaded patch set 1 11/19/25, 20:20

  2. Georg Ringer commented on patch set 1 11/19/25, 20:20

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/19/25, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90199

  4. Oliver Klee updated the commit message in patch set 2 V +1 11/20/25, 08:48

  5. core-ci voted on patch set 2 V +1 11/20/25, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90238

  6. Oli Bartsch commented on patch set 2 CR +1 V +1 11/20/25, 09:04

    I don't like the fact, that the record shows an empty "Entry point [identifier]" field, while there is actually a value in the database. However, might be a topic for a separate change.
  7. Christian Kuhn voted on patch set 2 CR +2 V +2 11/20/25, 10:18

  8. Christian Kuhn commented on patch set 2 11/20/25, 10:21

    agreed to oli bartsch it's unfortunate the selector is empty. i think there were approaches to deal with that already and we should have a look again. the selector modal has various ux issues, too (e.g. can not select from tree compontent directly, the checkbox madness in main section does not make sense, the 'link to button' naming is questionable). would be great to give it some love. both things are topics of other patches, let's get rid of the fatal now.
  9. Christian Kuhn updated the commit message in patch set 3 CR +1 V +1 11/20/25, 11:04

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 11/20/25, 11:04

  11. core-ci voted on patch set 3 V +1 11/20/25, 11:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90263

  12. Christian Kuhn merged patch set 4 11/20/25, 11:21