Review main Merged

91764[BUGFIX] Have simple cropper VH in ext:install

Christian Kuhn CR +2 V +2 Normal +108 −11 updated 11/20/25, 08:51

Commit message

We made ext:fluid CropViewHelper DI aware in #108161
but missed it is used in ext:install where container
is not fully loaded, leading to fatals in 'Configure
Installation-Wide Options'.

We could hard code DI config for this case, but ext:install
uses a fraction of the VH functionality only, it is easier
to just use a more slim own version of that view helper
instead.

Note we may end up adding basic string cropping to fluid
standalone directly, so this view helper may also vanish
later again.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 810

  1. Christian Kuhn uploaded patch set 1 11/20/25, 01:01

  2. Christian Kuhn updated the commit message in patch set 2 11/20/25, 01:03

  3. core-ci voted on patch set 1 V +1 11/20/25, 01:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90210

  4. core-ci voted on patch set 2 V +1 11/20/25, 01:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90213

  5. Benjamin Franzke voted on patch set 2 CR +1 V +1 11/20/25, 06:16

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 11/20/25, 07:48

  7. Oli Bartsch voted on patch set 2 CR +1 V +1 11/20/25, 08:18

  8. Oliver Klee voted on patch set 2 CR +1 11/20/25, 08:49

  9. Georg Ringer voted on patch set 2 CR +2 V +2 11/20/25, 08:51

  10. Georg Ringer merged patch set 3 11/20/25, 08:51