91772[TASK] Backport AsAllowedCallable attribute for TYPO3 v14 compatibility
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1113
-
Oliver Hader uploaded patch set 1 11/20/25, 16:35
-
core-ci voted on patch set 1 V +1 11/20/25, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90319
-
Oli Bartsch commented on patch set 1 11/20/25, 16:59
-
Oliver Hader commented on patch set 1 11/20/25, 17:02
AsAllowedCallable.php:27ReplyYou reviewed this change today and modified the class name - that was literally only a few pixels next to the section you're complaining about right now 🤣 -
Oliver Hader commented on patch set 2
V +111/20/25, 17:02Published edit on patch set 1. -
Oliver Hader commented on patch set 2 11/20/25, 17:03
AsAllowedCallable.php:27ReplyDone -
core-ci voted on patch set 2 V +1 11/20/25, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90327
-
Oli Bartsch commented on patch set 2 11/20/25, 17:19
AsAllowedCallable.php:27ReplyYes. The patch I reviewed earlier today was targeting v14 only, where `readonly` is fine to use (even not necessary in the current state). 🤷🏼♂️ -
Oli Bartsch voted on patch set 2 CR +1 V +1 11/20/25, 17:19
-
Christian Kuhn voted on patch set 2 CR +1 V +1 11/20/25, 17:51
-
Oliver Hader commented on patch set 2 11/20/25, 18:48
AsAllowedCallable.php:27ReplyI think TYPO3 should be consistent then, and drop `readonly` in v14 as well: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91783 -
Oliver Hader voted on patch set 2 CR +2 V +2 11/20/25, 18:48
-
Oliver Hader merged patch set 3 11/20/25, 18:49
AsAllowedCallable.php:27