Review 13.4 Merged

91772[TASK] Backport AsAllowedCallable attribute for TYPO3 v14 compatibility

Oliver Hader CR +2 V +2 Easy +30 −0 updated 11/20/25, 18:49

Commit message

This change backports the TYPO3\CMS\Core\Attribute\AsAllowedCallable
attribute that was added to TYPO3 v14.0. The attribute is now available
in earlier TYPO3 releases so that extensions can use it without breaking
compatibility. No functional changes are introduced, the change simply
provides the attribute definition for older TYPO3 versions.

Details about the corresponding change in TYPO3 v14.0 are provided at:
https://docs.typo3.org/permalink/changelog:breaking-108054-1762881326

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1113

  1. Oliver Hader uploaded patch set 1 11/20/25, 16:35

  2. core-ci voted on patch set 1 V +1 11/20/25, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90319

  3. Oli Bartsch commented on patch set 1 11/20/25, 16:59

    AsAllowedCallable.php:27

    This is not possible in v12 and since there are no class properties, this is superfluous anyways.
  4. Oliver Hader commented on patch set 1 11/20/25, 17:02

    AsAllowedCallable.php:27 Reply

    You reviewed this change today and modified the class name - that was literally only a few pixels next to the section you're complaining about right now 🤣
  5. Oliver Hader commented on patch set 2 V +1 11/20/25, 17:02

    Published edit on patch set 1.
  6. Oliver Hader commented on patch set 2 11/20/25, 17:03

    AsAllowedCallable.php:27 Reply

    Done
  7. core-ci voted on patch set 2 V +1 11/20/25, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90327

  8. Oli Bartsch commented on patch set 2 11/20/25, 17:19

    AsAllowedCallable.php:27 Reply

    Yes. The patch I reviewed earlier today was targeting v14 only, where `readonly` is fine to use (even not necessary in the current state). 🤷🏼‍♂️
  9. Oli Bartsch voted on patch set 2 CR +1 V +1 11/20/25, 17:19

  10. Christian Kuhn voted on patch set 2 CR +1 V +1 11/20/25, 17:51

  11. Oliver Hader commented on patch set 2 11/20/25, 18:48

    AsAllowedCallable.php:27 Reply

    I think TYPO3 should be consistent then, and drop `readonly` in v14 as well: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91783
  12. Oliver Hader voted on patch set 2 CR +2 V +2 11/20/25, 18:48

  13. Oliver Hader merged patch set 3 11/20/25, 18:49