91773[TASK] Enhance CLI docs for runTests.sh -s watchRst
Commit message
Review
-
Code review CR +1
- Garvin Hicking +1
-
Verified V +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Markus Klein uploaded patch set 1 11/20/25, 16:48
-
Markus Klein uploaded patch set 2 11/20/25, 16:49
-
Markus Klein updated the commit message in patch set 3 11/20/25, 16:50
-
Markus Klein commented on patch set 3 11/20/25, 16:50
This change is ready for review. -
core-ci voted on patch set 1 V -1 11/20/25, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90322
-
Garvin Hicking commented on patch set 3 11/20/25, 16:53
runTests.sh:619When I read it like that my plan to have a single command really failed, the argument design is bad :( might need to get back to the drawing board on that, this help isn't really understandable IMO. -
Markus Klein commented on patch set 3 11/20/25, 16:57
runTests.sh:619ReplyThat's how I would have understood it. -
core-ci voted on patch set 2 V +1 11/20/25, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90324
-
core-ci voted on patch set 3 V +1 11/20/25, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/90325
-
Garvin Hicking commented on patch set 3 CR +1 V +1 11/20/25, 19:02
runTests.sh:619ReplyAlright, if it helps one person thats better than not helping. I might reflect on my CLI argument parsing life choices at a later time, if/when more people use it. I'll also provide docs in the contribution guide. -
Christian Kuhn commented on patch set 3 11/20/25, 19:08
runTests.sh:618any chance to shorten this? looks ugly even on my wide screen. maybe just a working concrete example instead? -
Markus Klein commented on patch set 3 11/21/25, 13:28
runTests.sh:618ReplyFeel free to adjust in any way. This was really only just a 1 minute patch after searching my way on how to use the command. (which works great btw 🤝) -
Garvin Hicking commented on patch set 3 12/10/25, 18:22
runTests.sh:618Reply Unresolved -
Christian Kuhn abandoned the change 12/11/25, 21:37
hope is ok to abandon here: this has been changed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/92080 -
Markus Klein commented on patch set 3 12/13/25, 14:25
@lolli@schwarzbu.ch actually we agreed in https://review.typo3.org/c/Packages/TYPO3.CMS/+/92080/comment/b2d02a29_40afb446/ to continue here for proper option description etc. I'll revive that one with a suggestion, when the time comes.